Issue 9307036: Revert Aura changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9307036: Revert Aura changes (Closed)

Created:
8 years, 10 months ago by Avi (use Gerrit)

Modified:
8 years, 10 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, pam+watch_chromium.org, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert Aura changes This reverts commits r120044 and r120053. '044 broke the Win Aura bot, '053 did not fix it, and it's been burning since. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120067

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -241 lines)			Patch
M	ash/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/ash.gyp	View	3 chunks	+0 lines, -54 lines	0 comments	Download
D	ash/ash_strings.grd	View	1 chunk	+0 lines, -127 lines	0 comments	Download
M	ash/launcher/app_launcher_button.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/launcher/app_launcher_button.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	ash/launcher/launcher_button_host.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	ash/launcher/launcher_view.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/launcher/launcher_view.cc	View	3 chunks	+0 lines, -30 lines	0 comments	Download
M	ash/launcher/tabbed_launcher_button.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/launcher/tabbed_launcher_button.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	ash/test/test_suite.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	tools/gritsettings/resource_ids	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Zachary Kuznia

8 years, 10 months ago (2012-02-01 17:14:23 UTC) #2

On 2012/02/01 16:26:22, Avi wrote:
> Please don't leave bots burning :(

lgtm