Fix DCHECK with Trailing Slash.

chrome/browser/autocomplete/history_quick_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/history_quick_provider.h"
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/i18n/break_iterator.h"
@@ skipping 110 matching lines @@
 
   // Format the URL autocomplete presentation.
   std::vector<size_t> offsets =
       OffsetsFromTermMatches(history_match.url_matches);
   const net::FormatUrlTypes format_types = net::kFormatUrlOmitAll &
       ~(!history_match.match_in_scheme ? 0 : net::kFormatUrlOmitHTTP);
   match.fill_into_edit =
       AutocompleteInput::FormattedStringWithEquivalentMeaning(info.url(),
           net::FormatUrlWithOffsets(info.url(), languages_, format_types,
               net::UnescapeRule::SPACES, NULL, NULL, &offsets));
+  history::TermMatches new_matches =
+      ReplaceOffsetsInTermMatches(history_match.url_matches, offsets);
   match.contents = net::FormatUrl(info.url(), languages_, format_types,
               net::UnescapeRule::SPACES, NULL, NULL, NULL);
-  history::TermMatches new_matches =
-      ReplaceOffsetsInTermMatches(history_match.url_matches, offsets);
   match.contents_class =
       SpansFromTermMatch(new_matches, match.contents.length(), true);
 
   if (prevent_inline_autocomplete || !history_match.can_inline) {
     match.inline_autocomplete_offset = string16::npos;
   } else {
     DCHECK(!new_matches.empty());
     match.inline_autocomplete_offset = new_matches[0].offset +
         new_matches[0].length;
-    DCHECK_LE(match.inline_autocomplete_offset, match.fill_into_edit.length());
+    // The following will happen if the user has typed an URL with a scheme
+    // and the last character typed is a slash because that slash is removed
+    // by the FormatURLWithOffsets call above.

[Peter Kasting, 2012/02/02 06:35:14]

We should not be stripping slashes that the user typed.  If that's what's
happening, this isn't the right fix.

How does the HUP handle this scenario?

+    if (match.inline_autocomplete_offset > match.fill_into_edit.length())
+      match.inline_autocomplete_offset = match.fill_into_edit.length();
   }
 
   // Format the description autocomplete presentation.
   match.description = info.title();
   match.description_class = SpansFromTermMatch(
       history_match.title_matches, match.description.length(), false);
 
   return match;
 }
 
@@ skipping 49 matching lines @@
     do {
       offset += matches[i].length;
       ++i;
     } while ((i < match_count) && (offset == matches[i].offset));
     if (offset < text_length)
       spans.push_back(ACMatchClassification(offset, url_style));
   }
 
   return spans;
 }