Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 9307018: Linux: make BrowserWindowGtk's window reconfigure timer more transparent to tests. (Closed)

Created:
8 years, 10 months ago by Mike Mammarella
Modified:
8 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: use the bounds from the most recent BrowserWindowGtk::OnConfigure() call to figure out whether to return early in a later call, rather than bounds that may also be updated by a debounced callback with different (but more accurate, for some window managers) values. BUG=112041 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Mammarella
8 years, 10 months ago (2012-01-31 23:20:56 UTC) #1
Evan Stade
lgtm
8 years, 10 months ago (2012-02-01 05:06:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdm@chromium.org/9307018/1
8 years, 10 months ago (2012-02-01 08:21:05 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-01 10:01:44 UTC) #4
Change committed as 120050

Powered by Google App Engine
This is Rietveld 408576698