uber settings - checkbox/radio clickability

uber settings - checkbox/radio clickability

change labels to -webkit-inline-box. This doesn't change the children but the box itself will behave like an inline element rather than block (won't expand horizontally). Also remove box flex on the span as it's not necessary. Also add some padding on the end of the labels so that there is extra clickable area when the text is short (this doesn't change anything if the span is long enough to wrap).

In native dialogs:
On Linux/GTK, the clickable area extends all the way to the right (our behavior before this patch).
On Mac, the clickable area is only the text and the checkbox
On Windows, the clickable area extends beyond the text but not all the way to the far right.

I'm splitting the difference by matching Windows native behavior, which seems both logical and the middle road.

BUG=112091
TEST=1. Checkbox labels should be clickable on either the text or the checkbox, but not more than 100px from the right edge of the checkbox. 2. Long labels still wrap with indent (see bug 109334)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120033

[Dan Beam, 2012-01-31 23:29:27]

lgtm (I'm not sure if I'd understand the comment without the bug, but couldn't
really think of a better one)

[csilv, 2012-01-31 23:56:39]

lgtm, but see comment.

https://chromiumcodereview.appspot.com/9307015/diff/1/chrome/browser/resource...
File chrome/browser/resources/shared/css/checkbox.css (right):

https://chromiumcodereview.appspot.com/9307015/diff/1/chrome/browser/resource...
chrome/browser/resources/shared/css/checkbox.css:123: -webkit-padding-end:
100px;
I'd be more comfortable without this or a smaller value (say 40px).

[Evan Stade, 2012-02-01 01:09:33]

http://codereview.chromium.org/9307015/diff/1/chrome/browser/resources/shared...
File chrome/browser/resources/shared/css/checkbox.css (right):

http://codereview.chromium.org/9307015/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/css/checkbox.css:123: -webkit-padding-end:
100px;
On 2012/01/31 23:56:40, csilv wrote:
> I'd be more comfortable without this or a smaller value (say 40px).

the justification is in the cl description. This more or less matches Windows,
and splits the difference between Mac and Linux. Even the bug reporter pointed
out that this was reasonable (although previously we had ignored the idea).