Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: runtime/bin/main.cc

Issue 9307003: Changes to the process implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update stable test binaries Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/builtin_natives.cc ('k') | runtime/bin/process.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index be36001948ce097ab2d804fb505987e7e96632f0..23afc15e33635753a86b0734161e9d5de5bc623d 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -14,6 +14,7 @@
#include "bin/eventhandler.h"
#include "bin/file.h"
#include "bin/platform.h"
+#include "bin/process.h"
#include "platform/globals.h"
// snapshot_buffer points to a snapshot if we link in a snapshot otherwise
@@ -571,7 +572,13 @@ int main(int argc, char** argv) {
// Shutdown the isolate.
Dart_ShutdownIsolate();
// Terminate event handler.
+ // TODO(ager): This does not actually terminate any resources of the
+ // eventhandler. The only thing it currently terminates is the
+ // global thread-pool. In order to properly terminate the event
+ // handlers we need to be able to tell when an isolate dies so we
+ // can stop the thread for the event loop in that isolate.
EventHandler::Terminate();
-
+ // Terminate process exit-code handler.
+ Process::TerminateExitCodeHandler();
return 0;
}
« no previous file with comments | « runtime/bin/builtin_natives.cc ('k') | runtime/bin/process.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698