Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 9307001: [Mac] More tweaks to the Lion gesture UI. (Closed)

Created:
8 years, 10 months ago by Robert Sesek
Modified:
8 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

[Mac] More tweaks to the Lion gesture UI. * Fade the overlay out before navigating. * When the gesture is "committed," grow the overlay a little and use 75% opacity. * Track the opacity from [0.25, 0.65] before committing. * Increase the fade duration. BUG=93185 TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -17 lines) Patch
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm View 1 chunk +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/history_overlay_controller.mm View 6 chunks +26 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Sesek
8 years, 10 months ago (2012-01-31 16:27:37 UTC) #1
Nico
Code looks fine. I patched it in and played a bit with it. If I ...
8 years, 10 months ago (2012-01-31 17:32:41 UTC) #2
Robert Sesek
On 2012/01/31 17:32:41, Nico wrote: > Code looks fine. > > I patched it in ...
8 years, 10 months ago (2012-01-31 17:35:35 UTC) #3
Nico
On 2012/01/31 17:35:35, rsesek wrote: > On 2012/01/31 17:32:41, Nico wrote: > > Code looks ...
8 years, 10 months ago (2012-01-31 17:37:53 UTC) #4
Robert Sesek
8 years, 10 months ago (2012-01-31 17:49:28 UTC) #5
On 2012/01/31 17:37:53, Nico wrote:
> On 2012/01/31 17:35:35, rsesek wrote:
> > On 2012/01/31 17:32:41, Nico wrote:
> > > Code looks fine.
> > > 
> > > I patched it in and played a bit with it. If I don't pay attention to the
> size
> > > change, I don't notice it happening. If I do pay attention, I don't like
> that
> > > the size just jumps up instead of animating. Maybe the increase should be
a
> > lot
> > > more dramatical, and it should animate to that new size (and animate out
> > > opacity)?
> > 
> > According to Cole it's supposed to jump, not animate. I initially had the
> adjust
> > be 20px instead of 10px, but it made things look too ovalish.
> 
> I'd add the 20px to the circle radius, not to the height (and I'd probably add
> more like 50px), and animate the radius up and opacity down.
> 
> But if you don't feel like trying that and Cole likes this as is, lgtm as is
> too.

I think I'll land this and then let him play with it in Canary tomorrow, and
maybe do another iteration after his feedback.

Powered by Google App Engine
This is Rietveld 408576698