Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: tools/testing/run_selenium.py

Issue 9303019: Prevent browser windows from staying open. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/run_selenium.py
===================================================================
--- tools/testing/run_selenium.py (revision 3704)
+++ tools/testing/run_selenium.py (working copy)
@@ -89,10 +89,13 @@
action = 'store', default = '')
parser.add_option('--browser', dest='browser',
help = 'The browser type (default = chrome)',
- action = 'store', default = 'chrome')
+ action = 'store', default = 'chrome')
+ # TODO(efortuna): Put this back up to 40 sec. Right now it needs to be less
+ # than 20 so that when test.dart times out, this script also closes the
+ # browser windows.
parser.add_option('--timeout', dest = 'timeout',
help = 'Amount of time (seconds) to wait before timeout', type = 'int',
- action = 'store', default=40)
+ action = 'store', default=18)
parser.add_option('--perf', dest = 'is_perf',
help = 'Add this flag if we are running a browser performance test',
action = 'store_true', default=False)
« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698