Issue 9303005: [NTP4] Experiment for adding Chrome Web Store link to footer.

Issue 9303005: [NTP4] Experiment for adding Chrome Web Store link to footer. (Closed)

Created:
8 years, 10 months ago by Dan Beam

Modified:
8 years, 10 months ago

Reviewers:
orig, Evan Stade

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews), mihaip+watch_chromium.org, Aaron Boodman

Visibility:
Public.

More Reviews

Description

[NTP4] Experiment for adding Chrome Web Store link to footer. Contributed by Ori Gershony <orig@chromium.org>;. BUG=106580 R=orig@chromium.org,estade@chromium.org TEST=Use --enable-webstore-link to force the experiment on. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119793

Patch Set 2 : fixing RTL vertical separator issue #

Patch Set 3 : moving to global browser init to avoid crash when NTP resource cache is cleared #

Total comments: 2

Patch Set 4 : trails -> trials #

Patch Set 5 : copyright bump to make PRESUBMIT.py happy #

Patch Set 7 : rebase #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -22 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/theme/theme_resources.grd	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View	1 2 3	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/ntp4/apps_page.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.css	View		11 chunks	+59 lines, -12 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.html	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.js	View		2 chunks	+22 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/recently_closed.css	View	1	2 chunks	+25 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.h	View	1 2 3 4	2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.cc	View	1 2 3 4 5	6 chunks	+34 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2 3 4 5 6	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

this is just a re-application of orig's patch here: https://chromiumcodereview.appspot.com/8637001/, as the CQ has been ...

8 years, 10 months ago (2012-01-30 19:15:10 UTC) #2

orig

lgtm https://chromiumcodereview.appspot.com/9303005/diff/4013/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://chromiumcodereview.appspot.com/9303005/diff/4013/chrome/browser/chrome_browser_main.cc#newcode1033 chrome/browser/chrome_browser_main.cc:1033: NewTabUI::SetupFieldTrails(); SetupFieldTrial

8 years, 10 months ago (2012-01-30 22:38:22 UTC) #6

Dan Beam

https://chromiumcodereview.appspot.com/9303005/diff/4013/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://chromiumcodereview.appspot.com/9303005/diff/4013/chrome/browser/chrome_browser_main.cc#newcode1033 chrome/browser/chrome_browser_main.cc:1033: NewTabUI::SetupFieldTrails(); On 2012/01/30 22:38:23, orig wrote: > SetupFieldTrial Done.

8 years, 10 months ago (2012-01-30 22:43:12 UTC) #7

lgtm

Expand Messages | Collapse Messages