Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 9303001: Add support for lists to the C message reader (Closed)

Created:
8 years, 10 months ago by Søren Gjesse
Modified:
8 years, 10 months ago
Reviewers:
siva
CC:
Mads Ager (google), reviews_dartlang.org
Visibility:
Public.

Description

Add support for lists to the C message reader The C message reader can now read lists created like this: new List() new List<int>() new List<String>() new List<double>() new List<bool>() The handling of this should be updated when the new external message serialization format is finished. R=asiva@google.com, turnidge@google.com BUG= TEST=

Patch Set 1 #

Patch Set 2 : Removed the support for GrowableObjectArray #

Patch Set 3 : Removed unused function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -56 lines) Patch
M runtime/include/dart_api.h View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/platform/assert.h View 3 chunks +13 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 2 chunks +30 lines, -8 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 8 chunks +50 lines, -19 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 9 chunks +151 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Søren Gjesse
8 years, 10 months ago (2012-01-30 14:36:04 UTC) #1
siva
Do you think this change is necessary if we implment the isolate message protocol that ...
8 years, 10 months ago (2012-01-31 05:09:46 UTC) #2
Søren Gjesse
We do need to make progress on native messages, so support for Lists is needed. ...
8 years, 10 months ago (2012-01-31 10:50:03 UTC) #3
turnidge
I scanned this change and didn't see anything to note for you. I'm relying on ...
8 years, 10 months ago (2012-01-31 22:16:30 UTC) #4
siva
Would it be possible to update this changelist with the latest changes you have for ...
8 years, 10 months ago (2012-02-02 05:47:45 UTC) #5
Søren Gjesse
8 years, 10 months ago (2012-02-02 10:21:44 UTC) #6
This Cl was combined with http://codereview.chromium.org/9303031/.

Closing.

Powered by Google App Engine
This is Rietveld 408576698