Issue 9302035: Re-add source files to gyp config for gcapi_dll. Removing them seems to make VS2005 unhappy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9302035: Re-add source files to gyp config for gcapi_dll. Removing them seems to make VS2005 unhappy. (Closed)

Created:
8 years, 10 months ago by robertshield

Modified:
8 years, 10 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Re-add source files to gyp config for gcapi_dll. Removing them seems to make VS2005 unhappy. Revert "Revert 119841 - Implementation of GCAPI reactivation." This reverts commit b0eebb403ad069142ec43e566134f4000f0f0f19. (https://chromiumcodereview.appspot.com/9302029/) BUG=111453 TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119940

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+414 lines, -5 lines)			Patch
M	chrome/chrome_installer.gypi	View	3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi.h	View	3 chunks	+43 lines, -2 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi.cc	View	2 chunks	+72 lines, -0 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi.def	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/installer/gcapi/gcapi_reactivation.h	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A	chrome/installer/gcapi/gcapi_reactivation.cc	View	1 chunk	+77 lines, -0 lines	0 comments	Download
A	chrome/installer/gcapi/gcapi_reactivation_test.cc	View	1 chunk	+186 lines, -0 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi_test.cc	View	2 chunks	+10 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

robertshield

This is a revert of the revert of the previous CL. The only difference is ...

8 years, 10 months ago (2012-01-31 17:04:04 UTC) #1

Roger Tawa OOO till Jul 10th

8 years, 10 months ago (2012-01-31 18:37:59 UTC) #2

lgtm

Sorry for the original suggestion.