Issue 9302030: Fix build when webrtc is disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9302030: Fix build when webrtc is disabled (Closed)

Created:
8 years, 10 months ago by Henrik Grunell

Modified:
8 years, 10 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix build when webrtc is disabled; i.e. when enable_webrtc is set to 0 in build/common.gypi. Building with webrtc disabled is currently not tested by any build bots. Landing the support for PeerConnection v2 (instead of v1) in 119568 broke the build when webrtc is disabled. The stub implementations must be updated to reflect the new interfaces. TEST=Set enable_webrtc to 0 in build/common.gypi; build chrome. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119888

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -32 lines)			Patch
	M	content/renderer/media/media_stream_dependency_factory_stub.cc	View		1 chunk	+26 lines, -16 lines	0 comments	Download
	M	content/renderer/media/media_stream_impl_stub.cc	View		6 chunks	+8 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

8 years, 10 months ago (2012-01-31 10:58:14 UTC) #2

tommi (sloooow) - chröme

On 2012/01/31 10:58:14, I haz the power (commit-bot) wrote: > No LGTM from a valid ...

8 years, 10 months ago (2012-01-31 10:58:49 UTC) #3

lgtm

Expand Messages | Collapse Messages