Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2519)

Unified Diff: content/renderer/render_view_impl.cc

Issue 9302022: WebWidgetClient::screenInfo() no longer does a synchronous IPC. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index b76e2a8a26c6df7b90b193639497dd4a0a1f6333..553920ce23613f77ba6086a2aec80aa83f6dfaba 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -376,8 +376,9 @@ RenderViewImpl::RenderViewImpl(
int32 surface_id,
int64 session_storage_namespace_id,
const string16& frame_name,
- int32 next_page_id)
- : RenderWidget(WebKit::WebPopupTypeNone),
+ int32 next_page_id,
+ const WebKit::WebScreenInfo& screen_info)
+ : RenderWidget(WebKit::WebPopupTypeNone, screen_info),
webkit_preferences_(webkit_prefs),
send_content_state_immediately_(false),
enabled_bindings_(0),
@@ -562,7 +563,8 @@ RenderViewImpl* RenderViewImpl::Create(
int32 surface_id,
int64 session_storage_namespace_id,
const string16& frame_name,
- int32 next_page_id) {
+ int32 next_page_id,
+ const WebKit::WebScreenInfo& screen_info) {
DCHECK(routing_id != MSG_ROUTING_NONE);
return new RenderViewImpl(
parent_hwnd,
@@ -574,7 +576,8 @@ RenderViewImpl* RenderViewImpl::Create(
surface_id,
session_storage_namespace_id,
frame_name,
- next_page_id); // adds reference
+ next_page_id,
+ screen_info);
}
WebKit::WebPeerConnectionHandler* RenderViewImpl::CreatePeerConnectionHandler(
@@ -1411,7 +1414,8 @@ WebView* RenderViewImpl::createView(
surface_id,
cloned_session_storage_namespace_id,
frame_name,
- 1);
+ 1,
+ screen_info_);
view->opened_by_user_gesture_ = params.user_gesture;
// Record whether the creator frame is trying to suppress the opener field.
@@ -1431,7 +1435,8 @@ WebView* RenderViewImpl::createView(
}
WebWidget* RenderViewImpl::createPopupMenu(WebKit::WebPopupType popup_type) {
- RenderWidget* widget = RenderWidget::Create(routing_id_, popup_type);
+ RenderWidget* widget =
+ RenderWidget::Create(routing_id_, popup_type, screen_info_);
return widget->webwidget();
}

Powered by Google App Engine
This is Rietveld 408576698