WebWidgetClient::screenInfo() no longer does a synchronous IPC.

content/browser/renderer_host/render_view_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 179 matching lines @@
   ViewMsg_New_Params params;
   params.parent_window = GetNativeViewId();
   params.renderer_preferences =
       delegate_->GetRendererPrefs(process()->GetBrowserContext());
   params.web_preferences = delegate_->GetWebkitPrefs();
   params.view_id = routing_id();
   params.surface_id = surface_id();
   params.session_storage_namespace_id = session_storage_namespace_->id();
   params.frame_name = frame_name;
   params.next_page_id = next_page_id;
+#if defined(OS_POSIX) || defined(USE_AURA)
+  if (view())
+    view()->GetScreenInfo(&params.screen_info);
+  else
+    RenderWidgetHostView::GetDefaultScreenInfo(&params.screen_info);
+#else
+  params.screen_info =
+      params.WebKit::WebScreenInfoFactory::screenInfo(

[lain Merrick, 2012/01/31 12:42:09]

params.WebKit looks wrong.

And this may still call screenInfo() with NULL, right? Maybe just add a NULL
check here?

[Fady Samuel, 2012/01/31 19:54:12]

It probably is. I'm trying to update and test on Windows now (I mostly working
on Linux so there's a bit of latency to get a fresh sync'ed version of chromium
tested with this patch on Windows).

+          gfx::NativeViewFromId(GetNativeViewId()));
+#endif
+
   Send(new ViewMsg_New(params));
 
   // If it's enabled, tell the renderer to set up the Javascript bindings for
   // sending messages back to the browser.
   Send(new ViewMsg_AllowBindings(routing_id(), enabled_bindings_));
   // Let our delegate know that we created a RenderView.
   delegate_->RenderViewCreated(this);
 
   FOR_EACH_OBSERVER(
       content::RenderViewHostObserver, observers_, RenderViewHostInitialized());
@@ skipping 1324 matching lines @@
 
 void RenderViewHost::OnWebUISend(const GURL& source_url,
                                  const std::string& name,
                                  const base::ListValue& args) {
   delegate_->WebUISend(this, source_url, name, args);
 }
 
 void RenderViewHost::ClearPowerSaveBlockers() {
   STLDeleteValues(&power_save_blockers_);
 }