Fix an SECItem leak in the new ECSignatureCreator class.

crypto/ec_signature_creator_nss.cc

Index: crypto/ec_signature_creator_nss.cc
diff --git a/crypto/ec_signature_creator_nss.cc b/crypto/ec_signature_creator_nss.cc
index 147535b28e9a1d3de08bec3ffa13c141c567bf6d..05230ee21b062107982a504cbf4ed22797704bf7 100644
--- a/crypto/ec_signature_creator_nss.cc
+++ b/crypto/ec_signature_creator_nss.cc
@@ -93,6 +93,7 @@ bool ECSignatureCreator::Sign(const uint8* data,
 
   // Copy the signed data into the output vector.
   signature->assign(result->data, result->data + result->len);
+  SECITEM_FreeItem(result, PR_FALSE);

[agl, 2012/01/31 15:40:55]

Thanks for catching this, but there's an underlying error here that should be
cleaned up.

|arena| is created and passed to |SignData|, but |SignData| doesn't use it, nor
can it. So |arena| should be removed, the first argument to SECITEM_AllocItem
should be "NULL /* no arena */". Lastly, the first argument to SignData should
be removed and then this line should be:

SECITEM_FreeItem(result, PR_TRUE /* also free |result| itself */);

[Ryan Hamilton, 2012/01/31 16:37:16]

No kidding?  Thanks for catching this.  As per wtc's suggestion, I used
x509_util_nss.cc 's SignCertificate method as the basis for this implementation.
 When it invokes SignData, should it also not being using the arena?

   return true;
 }