Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: tools/testing/run_selenium.py

Issue 9302012: Better way to fix console.log in IE. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« frog/lib/corelib.dart ('K') | « tools/testing/dart/test_suite.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/run_selenium.py
===================================================================
--- tools/testing/run_selenium.py (revision 3703)
+++ tools/testing/run_selenium.py (working copy)
@@ -92,7 +92,7 @@
action = 'store', default = 'chrome')
parser.add_option('--timeout', dest = 'timeout',
help = 'Amount of time (seconds) to wait before timeout', type = 'int',
- action = 'store', default=10)
+ action = 'store', default=40)
parser.add_option('--perf', dest = 'is_perf',
help = 'Add this flag if we are running a browser performance test',
action = 'store_true', default=False)
@@ -108,7 +108,7 @@
if browser == 'chrome':
browser = selenium.webdriver.Chrome()
elif browser == 'ff':
- browser = selenium.webdriver.Firefox()
+ browser = selenium.webdriver.Firefox()
elif browser == 'ie' and platform.system() == 'Windows':
browser = selenium.webdriver.Ie()
elif browser == 'safari' and platform.system() == 'Darwin':
@@ -141,8 +141,9 @@
else:
return 0
else:
- # We're running a correctness test.
- if ('PASS' in source):
+ # We're running a correctness test. Mark test as passing if all individual
+ # test cases pass.
+ if 'FAIL' not in source and 'PASS' in source:
print 'Content-Type: text/plain\nPASS'
return 0
else:
« frog/lib/corelib.dart ('K') | « tools/testing/dart/test_suite.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698