Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: frog/leg/emitter.dart

Issue 9301038: Support named arguments for statically resolved calls. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/leg/elements/elements.dart ('k') | frog/leg/lib/core.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/leg/emitter.dart
===================================================================
--- frog/leg/emitter.dart (revision 3723)
+++ frog/leg/emitter.dart (working copy)
@@ -44,8 +44,7 @@
// TODO(ngeoffray): also support invocation with names.
String invocationName =
namer.instanceMethodName(member.name, invocation.argumentCount);
- int allParameters = member.parameterCount(compiler)
- + member.optionalParameterCount(compiler);
+ int allParameters = member.parameterCount(compiler);
int missingParameters = allParameters - invocation.argumentCount;
if (missingParameters == 0) return;
assert(missingParameters > 0);
@@ -68,6 +67,7 @@
String prototype,
StringBuffer buffer) {
Set<Invocation> invocations = compiler.universe.invokedNames[member.name];
+ if (invocations == null) return;
for (Invocation invocation in invocations) {
if (!invocation.applies(compiler, member)) continue;
addParameterStub(member, prototype, buffer, invocation);
« no previous file with comments | « frog/leg/elements/elements.dart ('k') | frog/leg/lib/core.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698