Issue 9301031: Adding unittest for the reference counting of WebMediaStreamDescriptor/Source

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9301031: Adding unittest for the reference counting of WebMediaStreamDescriptor/Source (Closed)

Created:
8 years, 10 months ago by tommyw

Modified:
8 years, 10 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, hclam+watch_chromium.org, Alexander Potapenko, stuartmorgan+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), pam+watch_chromium.org, scherkus (not reviewing), Timur Iskhodzhanov, ihf+watch_chromium.org

Visibility:
Public.

More Reviews

Description

Adding unittest for the reference counting of WebMediaStreamDescriptor/Source BUG=105624, 111757 TEST=content_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120061

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -32 lines)			Patch
M	content/renderer/media/peer_connection_handler_unittest.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download
M	tools/heapcheck/suppressions.txt	View		2 chunks	+0 lines, -19 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

8 years, 10 months ago (2012-01-31 14:30:28 UTC) #3

On 2012/01/31 10:39:15, tommi wrote:
> lgtm!

fyi - still waiting on these bots:
http://build.chromium.org/p/tryserver.chromium/builders/mac_valgrind/builds/175
http://build.chromium.org/p/tryserver.chromium/builders/linux_valgrind/builds...

Expand Messages | Collapse Messages