Issue 9301007: Issue 561. Fix for methods named get/set/operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9301007: Issue 561. Fix for methods named get/set/operator. (Closed)

Created:
8 years, 10 months ago by scheglov

Modified:
8 years, 10 months ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 561. Fix for methods named get/set/operator. http://code.google.com/p/dart/issues/detail?id=561 R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3866

Patch Set 1 #

Patch Set 2 : Added shared test #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -3 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
M	tests/language/language-leg.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/src/MethodNameTest.dart	View	1	1 chunk	+35 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zundel

8 years, 10 months ago (2012-02-02 18:30:46 UTC) #3

LGTM with one nit

http://codereview.chromium.org/9301007/diff/4001/tests/language/src/MethodNam...
File tests/language/src/MethodNameTest.dart (right):

http://codereview.chromium.org/9301007/diff/4001/tests/language/src/MethodNam...
tests/language/src/MethodNameTest.dart:1: // Copyright (c) 2011, the Dart
project authors.  Please see the AUTHORS file
2012

Expand Messages | Collapse Messages