ui/android/DEPS - Issue 929903002: Remove cc dependency from ui/base

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/DEPS

Issue 929903002: Remove cc dependency from ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+cc/output/copy_output_request.h",
	spang 2015/02/23 19:22:44 You should be able to delete ui/base/android/DEPS You should be able to delete ui/base/android/DEPS now right? Jaekyun Seok (inactive) 2015/02/23 20:29:24 I've already removed the previous changes in ui/ba Show quoted text On 2015/02/23 19:22:44, spang wrote: > You should be able to delete ui/base/android/DEPS now right? I've already removed the previous changes in ui/base/android/DEPS. spang 2015/02/23 20:36:14 I'm not seeing any removal in the patch or in the Show quoted text On 2015/02/23 20:29:24, Jaekyun Seok (OOOuntilFeb23) wrote: > On 2015/02/23 19:22:44, spang wrote: > > You should be able to delete ui/base/android/DEPS now right? > > I've already removed the previous changes in ui/base/android/DEPS. I'm not seeing any removal in the patch or in the tree. Jaekyun Seok (inactive) 2015/02/23 20:44:07 This file is ui/android/DEPS, not ui/base/android/ Show quoted text On 2015/02/23 20:36:14, spang wrote: > On 2015/02/23 20:29:24, Jaekyun Seok (OOOuntilFeb23) wrote: > > On 2015/02/23 19:22:44, spang wrote: > > > You should be able to delete ui/base/android/DEPS now right? > > > > I've already removed the previous changes in ui/base/android/DEPS. > > I'm not seeing any removal in the patch or in the tree. This file is ui/android/DEPS, not ui/base/android/DEPS. You can see changes in ui/base/DEPS of patch set #4 gone in the latest patch set.
2 "+cc/resources/ui_resource_client.h",	3 "+cc/resources/ui_resource_client.h",

3 "+cc/resources/ui_resource_bitmap.h",	4 "+cc/resources/ui_resource_bitmap.h",

4 "+cc/trees/layer_tree_host.h",	5 "+cc/trees/layer_tree_host.h",

5 "+jni",	6 "+jni",

6 "+skia/ext",	7 "+skia/ext",

7 "+third_party/skia",	8 "+third_party/skia",

8 "+ui/base/resource/resource_bundle.h",	9 "+ui/base/resource/resource_bundle.h",

9 "+ui/base/ui_base_paths.h",	10 "+ui/base/ui_base_paths.h",

10 "+ui/gfx",	11 "+ui/gfx",

11 ]	12 ]

OLD	NEW

« no previous file with comments | « ui/android/BUILD.gn ('k') | ui/android/ui_android.gyp » ('j') | no next file with comments »