Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: client/tools/buildbot_annotated_steps.py

Issue 9298028: Fix dartc tests, and second half of r3585 for Windows. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | tools/testing/dart/test_suite.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/tools/buildbot_annotated_steps.py
===================================================================
--- client/tools/buildbot_annotated_steps.py (revision 3627)
+++ client/tools/buildbot_annotated_steps.py (working copy)
@@ -182,14 +182,16 @@
build and test experimental frog build
'''
print 'ProcessFrog'
+ has_shell=False
if 'windows' in name:
- os.environ['PATH'] = (os.path.join('C:', 'Program Files (x86)', 'nodejs') +
- os.pathsep + os.environ['PATH'])
- # In Windows we need to run in the shell, so that we have all the
- # environment variables available.
- return subprocess.call([sys.executable + ' ' +
+ os.environ['PATH'] = (os.path.join('C:', 'Program Files (x86)', 'nodejs') +
+ os.pathsep + os.environ['PATH'])
+ # In Windows we need to run in the shell, so that we have all the
+ # environment variables available.
+ has_shell=True
+ return subprocess.call([sys.executable,
os.path.join('frog', 'scripts', 'buildbot_annotated_steps.py')],
- env=os.environ, shell=True)
+ env=os.environ, shell=has_shell)
def main():
print 'main'
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | tools/testing/dart/test_suite.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698