Issue 9298009: Implementing full screen mode for video player in Chrome OS File Browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9298009: Implementing full screen mode for video player in Chrome OS File Browser. (Closed)

Created:
8 years, 11 months ago by Vladislav Kaznacheev

Modified:
8 years, 10 months ago

Reviewers:
dgozman, SeRya

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implementing full screen mode for video player in Chrome OS File Browser. BUG=chromium-os:23978 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119668

Patch Set 1 #

Patch Set 2 : Copyright fix #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -16 lines)			Patch
M	chrome/browser/resources/file_manager/js/file_manager.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery.css	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery.js	View		2 chunks	+17 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery_demo.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/media_controls.css	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/media_controls.js	View		4 chunks	+9 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

Hi, Please review this small patch. With the help of jeremya I implemented the full ...

8 years, 11 months ago (2012-01-27 13:25:51 UTC) #1

Vladislav Kaznacheev

Thanks, committing. Also abandoning the old review(http://codereview.chromium.org/9288062/) that this one replaced.

8 years, 10 months ago (2012-01-30 13:39:54 UTC) #3

jeremya

8 years, 10 months ago (2012-01-31 02:30:06 UTC) #4

On 2012/01/30 13:39:54, Vladislav Kaznacheev wrote:
> Thanks, committing.
> 
> Also abandoning the old review(http://codereview.chromium.org/9288062/) that
> this one replaced.

lgtm too, in case you were wondering :)

Expand Messages | Collapse Messages