Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 9298003: MIPS: Add signal context definitions for use with Android. (Closed)

Created:
8 years, 11 months ago by Paul Lind
Modified:
8 years, 11 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Add signal context definitions for use with Android. As with Arm, the kernel defines this stuff, but bionic lib does not. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M src/platform-linux.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Lind
This is another Android specific change, which I had forgotten to upstream to you guys. ...
8 years, 11 months ago (2012-01-27 03:39:15 UTC) #1
danno
lgtm
8 years, 11 months ago (2012-01-27 08:57:19 UTC) #2
danno
8 years, 11 months ago (2012-01-27 11:49:33 UTC) #3
Actually, I take the LGTM back. Our presubmit scripts don't like the use of the
C types unsigned long and int. Please convert these to the platform unspecific
types, e.g. uint32_t.

Powered by Google App Engine
This is Rietveld 408576698