Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 9297046: Add WebKitPlatformSupport::createOffscreenGraphicsContext3D (Closed)

Created:
8 years, 11 months ago by piman
Modified:
8 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org
Visibility:
Public.

Description

Add WebKitPlatformSupport::createOffscreenGraphicsContext3D This is in preparation of https://bugs.webkit.org/show_bug.cgi?id=76593 BUG=99516 TEST=manually ran Chrome w/accelerated content, DRT, test_shell_tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119857

Patch Set 1 #

Patch Set 2 : add missing include #

Patch Set 3 : more missing includes #

Patch Set 4 : rebase #

Patch Set 5 : remove "renderDirectlyToWebView" parameter #

Patch Set 6 : churn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -6 lines) Patch
M content/renderer/render_view_impl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
piman
Yet another round... Hopefully the last one. kbr: please review tony: OWNERS
8 years, 10 months ago (2012-01-30 20:52:33 UTC) #1
tony
rubber stamp LGTM for webkit/
8 years, 10 months ago (2012-01-30 21:24:30 UTC) #2
piman
FYI, I uploaded a new patch to follow churn in the webkit-side...
8 years, 10 months ago (2012-01-30 22:43:21 UTC) #3
Ken Russell (switch to Gerrit)
LGTM; looks like the Linux try failure is unrelated.
8 years, 10 months ago (2012-01-31 01:17:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9297046/11002
8 years, 10 months ago (2012-01-31 01:22:26 UTC) #5
commit-bot: I haz the power
Try job failure for 9297046-11002 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 10 months ago (2012-01-31 02:55:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9297046/11002
8 years, 10 months ago (2012-01-31 03:00:05 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-01-31 05:39:08 UTC) #8
Change committed as 119857

Powered by Google App Engine
This is Rietveld 408576698