Issue 9297019: Fix and adapt debugger for new call target caches.

Issue 9297019: Fix and adapt debugger for new call target caches. (Closed)

Created:
8 years, 11 months ago by Michael Starzinger

Modified:
8 years, 11 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix and adapt debugger for new call target caches. R=yangguo@chromium.org TEST=mjsunit/debug-stepout-scope Committed: https://code.google.com/p/v8/source/detail?r=10540

Patch Set 2 : Addressed comments by Yang Guo. #

Created: 8 years, 11 months ago

	Unified diffs	Side-by-side diffs	Stats (+189 lines, -78 lines)
M	src/arm/debug-arm.cc	View	2 chunks	+31 lines, -9 lines	0 comments
M	src/builtins.h	View	1 chunk	+24 lines, -20 lines	0 comments
M	src/builtins.cc	View	2 chunks	+17 lines, -5 lines	0 comments
M	src/code-stubs.h	View	2 chunks	+8 lines, -0 lines	0 comments
M	src/debug.h	View	1 chunk	+3 lines, -1 line	0 comments
M	src/debug.cc	View	2 chunks	+18 lines, -17 lines	0 comments
M	src/ia32/debug-ia32.cc	View	2 chunks	+35 lines, -13 lines	0 comments
M	src/objects.h	View	2 chunks	+6 lines, -0 lines	0 comments
M	src/objects-inl.h	View	1 chunk	+12 lines, -0 lines	0 comments
M	src/x64/debug-x64.cc	View	2 chunks	+35 lines, -13 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2012/01/27 15:12:29, Michael Starzinger wrote: > This should fix build-bot redness. LGTM with a ...

8 years, 11 months ago (2012-01-27 15:52:25 UTC) #2

Yang

forgot to attach nit. https://chromiumcodereview.appspot.com/9297019/diff/1/src/code-stubs.h File src/code-stubs.h (right): https://chromiumcodereview.appspot.com/9297019/diff/1/src/code-stubs.h#newcode742 src/code-stubs.h:742: virtual void FinishCode(Handle<Code> code); You ...

8 years, 11 months ago (2012-01-27 15:52:38 UTC) #3

Michael Starzinger

8 years, 11 months ago (2012-01-27 16:10:52 UTC) #4

Added new patch set. Landed.

https://chromiumcodereview.appspot.com/9297019/diff/1/src/code-stubs.h
File src/code-stubs.h (right):

https://chromiumcodereview.appspot.com/9297019/diff/1/src/code-stubs.h#newcod...
src/code-stubs.h:742: virtual void FinishCode(Handle<Code> code);
On 2012/01/27 15:52:38, Yang wrote:
> You could inline this function here so that you don't have to copy the same
code
> all over the architectures.

Done.

Expand Messages | Collapse Messages