Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 9297006: Add per-tile painting support to compositor. (Closed)

Created:
8 years, 11 months ago by reveman
Modified:
8 years, 10 months ago
CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, dhollowa+watch_chromium.org, jonathan.backer
Visibility:
Public.

Description

Add per-tile painting support to compositor. Add --ui-enable-per-tile-painting to enable per-tile painting when built with use_canvas_skia_skia=1. BUG=111587 TEST=Build with use_aura=1, chromeos=1 and use_canvas_skia_skia=1. Run chrome --ui-enable-per-tile-painting. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122097

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ui/gfx/compositor/compositor.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/compositor/compositor.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gfx/compositor/compositor_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/compositor/compositor_switches.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
piman
LGTM for now. It would be really great to be able to have e.g. use_aura ...
8 years, 10 months ago (2012-02-14 21:09:21 UTC) #1
asvitkine_google
LGTM
8 years, 10 months ago (2012-02-14 21:13:20 UTC) #2
reveman
8 years, 10 months ago (2012-02-14 21:22:08 UTC) #3
On 2012/02/14 21:09:21, piman wrote:
> LGTM for now.
> It would be really great to be able to have e.g. use_aura always imply
> use_canvas_skia_skia, so that we can remove this ifdef at some point

 I agree. I'll make sure this gets done asap.

Powered by Google App Engine
This is Rietveld 408576698