Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 9297001: Backport fix for http://crbug.com/108871 to m17's 963 branch. (Closed)

Created:
8 years, 11 months ago by dgrogan
Modified:
8 years, 11 months ago
Reviewers:
jschuh
CC:
chromium-reviews, jstritar+watch_chromium.org, tfarina, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Backport fix for http://crbug.com/108871 to m17's 963 branch. Original CL description: Fix race condition in utility process clients A few clients of the utility process had a race condition that could lead to a browser crash if the utility process crashed. IndexedDB was the worst offender. WebstoreInstallHelper, the profile importer, and posix plugin loader were also affected. As a side effect, NaClProcessHost and GpuProcessHost are now notified when their respective processes are killed and treat such an occurrence as a crash. BUG=108871 TEST= 1) in Release mode, open http://trac.webkit.org/export/106000/trunk/LayoutTests/storage/indexeddb/cursor-reverse-bug.html 2) kill the utility process 3) reload 4) watch chrome not die Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119343

Patch Set 1 #

Patch Set 2 : empty change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -31 lines) Patch
M chrome/browser/extensions/webstore_install_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_install_helper.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/importer/external_process_importer_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/importer/external_process_importer_client.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/browser_child_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/idbbindingutilities_browsertest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_key_utility_client.cc View 7 chunks +20 lines, -13 lines 0 comments Download
M content/browser/plugin_loader_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_loader_posix.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/utility_process_host.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/utility_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jschuh
8 years, 11 months ago (2012-01-27 02:11:32 UTC) #1
lgtm for landing on branch

Powered by Google App Engine
This is Rietveld 408576698