mac: Always do history swiping on the NTP on lion devices with touchpad.

chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.h"
 
 #include <cmath>
 
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/debugger/devtools_window.h"
@@ skipping 152 matching lines @@
     gotUnhandledWheelEvent_ = false;
   }
 
   if (!render_widget_host_ || !render_widget_host_->IsRenderView())
     return NO;
   bool isDevtoolsRwhv = DevToolsWindow::IsDevToolsWindow(
       static_cast<RenderViewHost*>(render_widget_host_));
   if (isDevtoolsRwhv)
     return NO;
 
+  // TODO(thakis): This is wrong, as it will navigate the frontmost browser
+  // for swipe events on background windows. It also navigates the frontmost
+  // browser for swipes on extensions popups. And it's a dependency problem,
+  // too. http://crbug.com/102541

[Robert Sesek, 2012/01/30 17:13:18]

I think I have a fix for this either today or tomorrow. Yay!

[Nico, 2012/01/30 17:59:22]

Heh, I've been looking at this, too. I guess I'll stop looking then :-)

+  Browser* browser = BrowserList::GetLastActive();
+
+  if (browser && browser->IsOnNtp() &&
+      [NSEvent isSwipeTrackingFromScrollEventsEnabled]) {
+    // Always do history navigation on the NTP if it's enabled.
+    gotUnhandledWheelEvent_ = true;
+  }
+
   if (gotUnhandledWheelEvent_ &&
       [NSEvent isSwipeTrackingFromScrollEventsEnabled] &&
       [theEvent phase] == NSEventPhaseChanged) {
     totalScrollDelta_.width += [theEvent scrollingDeltaX];
     totalScrollDelta_.height += [theEvent scrollingDeltaY];
 
     bool isHorizontalGesture =
       std::abs(totalScrollDelta_.width) > std::abs(totalScrollDelta_.height);
 
     bool isRightScroll = [theEvent scrollingDeltaX] < 0;
     bool goForward = isRightScroll;
     bool canGoBack = false, canGoForward = false;
-    if (Browser* browser = BrowserList::GetLastActive()) {
+    if (browser) {
       canGoBack = browser->CanGoBack();
       canGoForward = browser->CanGoForward();
     }
 
     // If "forward" is inactive and the user rubber-bands to the right,
     // "isPinnedLeft" will be false.  When the user then rubber-bands to the
     // left in the same gesture, that should trigger history immediately if
     // there's no scrollbar, hence the check for hasHorizontalScrollbar_.
     bool shouldGoBack = isPinnedLeft_ || !hasHorizontalScrollbar_;
     bool shouldGoForward = isPinnedRight_ || !hasHorizontalScrollbar_;
@@ skipping 60 matching lines @@
 
           [historyOverlay setProgress:gestureAmount];
           if (isComplete) {
             [historyOverlay dismiss];
             [historyOverlay release];
           }
         }];
       return YES;
     }
   }
-  return NO;
+  return gotUnhandledWheelEvent_;
 }
 
 - (BOOL)validateUserInterfaceItem:(id<NSValidatedUserInterfaceItem>)item
                       isValidItem:(BOOL*)valid {
   SEL action = [item action];
 
   // For now, this action is always enabled for render view;
   // this is sub-optimal.
   // TODO(suzhe): Plumb the "can*" methods up from WebCore.
   if (action == @selector(checkSpelling:)) {
@@ skipping 64 matching lines @@
 }
 
 - (void)spellCheckEnabled:(BOOL)enabled checked:(BOOL)checked {
   spellcheck_enabled_ = enabled;
   spellcheck_checked_ = checked;
 }
 
 // END Spellchecking methods
 
 @end