[uber] Redoing the homepage selection UI

chrome/browser/prefs/session_startup_pref.h

Index: chrome/browser/prefs/session_startup_pref.h
diff --git a/chrome/browser/prefs/session_startup_pref.h b/chrome/browser/prefs/session_startup_pref.h
index c536da5cd5f0e335bc6957f45b63a3709d0b12bc..0ce3e879b1e858181ab2195c28a6c097faa36fad 100644
--- a/chrome/browser/prefs/session_startup_pref.h
+++ b/chrome/browser/prefs/session_startup_pref.h
@@ -17,8 +17,11 @@ class Profile;
 // StartupPref is stored in the preferences for a particular profile.
 struct SessionStartupPref {
   enum Type {
-    // Indicates the user doesn't want to restore a previous session.
-    DEFAULT,
+    // Indicates the user wants to open the New Tab page. This is the default.
+    NEWTAB,
+
+    // Deprecated. See comment in session_startup_pref.cc.
+    HOMEPAGE,

[csilv, 2012/02/01 20:37:29]

I recommend keeping the enum the same as it was.  the 'DEFAULT' value will
continue to exist, but the new meaning will be to show the new tab page.  See
comments in implementation for more details.

[Tyler Breisacher (Chromium), 2012/02/01 21:49:38]

Done.

 
     // Indicates the user wants to restore the last session.
     LAST,
@@ -41,8 +44,6 @@ struct SessionStartupPref {
   static bool TypeIsManaged(PrefService* prefs);
   static bool URLsAreManaged(PrefService* prefs);
 
-  SessionStartupPref();
-
   explicit SessionStartupPref(Type type);
 
   ~SessionStartupPref();