Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3181)

Unified Diff: chrome/browser/ui/browser_init.cc

Issue 9296038: [uber] Redoing the homepage selection UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: set prefs explicitly when OK clicked Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_init.cc
diff --git a/chrome/browser/ui/browser_init.cc b/chrome/browser/ui/browser_init.cc
index 7ceece02f5f02bbbf8d7ede7e19c9c4023adfd95..94eb9697980d853802055b499c60d3b538f8d54b 100644
--- a/chrome/browser/ui/browser_init.cc
+++ b/chrome/browser/ui/browser_init.cc
@@ -1107,11 +1107,16 @@ Browser* BrowserInit::LaunchWithProfile::ProcessSpecifiedURLs(
// specified on the command line. Filter out any urls that are to be
// restored by virtue of having been previously pinned.
AddUniqueURLs(pref.urls, &tabs);
- } else if (pref.type == SessionStartupPref::DEFAULT && !tabs.empty()) {
- // Make sure the home page is opened even if there are pinned tabs.
- std::vector<GURL> urls;
- AddStartupURLs(&urls);
- UrlsToTabs(urls, &tabs);
+ } else if (pref.type == SessionStartupPref::DEFAULT) {
+ BrowserInit::LaunchWithProfile::Tab tab;
+ tab.is_pinned = false;
+ tab.url = GURL(chrome::kChromeUINewTabURL);
+ tabs.push_back(tab);
+ } else if (pref.type == SessionStartupPref::HOMEPAGE) {
+ // If the user had 'homepage' selected, we should have migrated
+ // them to 'URLS' instead.
+ DLOG(ERROR) << "pref.type == HOMEPAGE";
+ NOTREACHED();
}
if (tabs.empty())

Powered by Google App Engine
This is Rietveld 408576698