Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1740)

Unified Diff: chrome/browser/resources/options2/browser_options.html

Issue 9296038: [uber] Redoing the homepage selection UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more fixes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/browser_options.html
diff --git a/chrome/browser/resources/options2/browser_options.html b/chrome/browser/resources/options2/browser_options.html
index 4fc6dc9aa4a611bf841205e707bbfbdec1b38199..a41a2341e79acc1aafe6fa79ccf84789eb362610 100644
--- a/chrome/browser/resources/options2/browser_options.html
+++ b/chrome/browser/resources/options2/browser_options.html
@@ -50,7 +50,7 @@
<div>
<div class="radio">
<label>
- <input type="radio" name="startup" value="0"
+ <input type="radio" name="startup" value="5"
pref="session.restore_on_startup"
metric="Options_Startup_Homepage">
<span i18n-content="startupShowDefaultAndNewTab"></span>
@@ -100,14 +100,15 @@
</div>
</if>
<div>
- <div class="checkbox">
- <input id="toolbarShowHomeButton" pref="browser.show_home_button"
- metric="Options_Homepage_HomeButton" type="checkbox">
- <label id="home-page-label" for="toolbarShowHomeButton"
- i18n-content="toolbarShowHomeButton">
- </label>
- <button id="change-home-page" i18n-content="changeHomePage"
- class="link-button"></button>
+ <div>
+ <label id="home-page-label" for="homepage-select"
+ i18n-content="homePage"></label>
csilv 2012/02/02 19:32:26 nit: 'home-page' vs 'homepage' in ids
Tyler Breisacher (Chromium) 2012/02/02 19:52:44 Done.
+ <select id="homepage-select">
+ <option value="none" i18n-content="homePageNone"></option>
+ <option value="ntp" i18n-content="homePageNtp"></option>
+ <option value="url"></option>
+ <option value="choose" i18n-content="homePageChoose"></option>
+ </select>
</div>
<div class="checkbox">
<label>

Powered by Google App Engine
This is Rietveld 408576698