chrome/browser/resources/options2/browser_options.html - Issue 9296038: [uber] Redoing the homepage selection UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options2/browser_options.html

Issue 9296038: [uber] Redoing the homepage selection UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CSS spacing + copy value change to chromeos section Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/options2/browser_options.html

diff --git a/chrome/browser/resources/options2/browser_options.html b/chrome/browser/resources/options2/browser_options.html

index 4fc6dc9aa4a611bf841205e707bbfbdec1b38199..709a1051f0656f1cfb063c7958ee8ce018a60ff9 100644

--- a/chrome/browser/resources/options2/browser_options.html

+++ b/chrome/browser/resources/options2/browser_options.html

@@ -50,7 +50,7 @@

<div>

<label>

- <input type="radio" name="startup" value="0"

+ <input type="radio" name="startup" value="5"

pref="session.restore_on_startup"

metric="Options_Startup_Homepage">

Tyler Breisacher (Chromium) 2012/02/03 01:57:41 Sorry, noticed one more thing. This metric no long

@@ -100,14 +100,15 @@

</div>

</if>

<div>

- <div class="checkbox">

- <input id="toolbarShowHomeButton" pref="browser.show_home_button"

- metric="Options_Homepage_HomeButton" type="checkbox">

- <label id="home-page-label" for="toolbarShowHomeButton"

- i18n-content="toolbarShowHomeButton">

- </label>

- <button id="change-home-page" i18n-content="changeHomePage"

- class="link-button"></button>

+ <div id="home-page-select-container">

+ <label id="home-page-label" for="home-page-select"

+ i18n-content="homePage"></label>

+ <select id="home-page-select">

+ <option value="none" i18n-content="homePageNone"></option>

+ <option value="ntp" i18n-content="homePageNtp"></option>

+ <option value="url"></option>

+ <option value="choose" i18n-content="homePageChoose"></option>

+ </select>

</div>

<label>

@@ -262,7 +263,7 @@

<div>

<label>

- <input type="radio" name="startup" value="0"

+ <input type="radio" name="startup" value="5"

pref="session.restore_on_startup"

metric="Options_Startup_Homepage">

« no previous file with comments | « chrome/browser/resources/options2/browser_options.css ('k') | chrome/browser/resources/options2/browser_options.js » ('j') | no next file with comments »