Chromium Code Reviews Chromium Code Reviews
Issue 9296038:
[uber] Redoing the homepage selection UI (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 <div id="browserPage" class="page" hidden> | 1 <div id="browserPage" class="page" hidden> |
| 2 <header> | 2 <header> |
| 3 <h1 i18n-content="browserPage"></h1> | 3 <h1 i18n-content="browserPage"></h1> |
| 4 <span id="browser-options-search-field-container" | 4 <span id="browser-options-search-field-container" |
| 5 class="search-field-container"> | 5 class="search-field-container"> |
| 6 <input id="search-field" type="search" | 6 <input id="search-field" type="search" |
| 7 i18n-values="placeholder:searchPlaceholder; | 7 i18n-values="placeholder:searchPlaceholder; |
| 8 aria-label:searchPlaceholder" incremental> | 8 aria-label:searchPlaceholder" incremental> |
| 9 </span> | 9 </span> |
| 10 </header> | 10 </header> |
| (...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 93 </div> | 93 </div> |
| 94 </div> | 94 </div> |
| 95 </if> | 95 </if> |
| 96 <if expr="pp_ifdef('toolkit_views') or os == 'win32' or os == 'darwin'"> | 96 <if expr="pp_ifdef('toolkit_views') or os == 'win32' or os == 'darwin'"> |
| 97 <div> | 97 <div> |
| 98 <button id="themes-gallery" i18n-content="themesGallery"></button> | 98 <button id="themes-gallery" i18n-content="themesGallery"></button> |
| 99 <button id="themes-reset" i18n-content="themesReset"></button> | 99 <button id="themes-reset" i18n-content="themesReset"></button> |
| 100 </div> | 100 </div> |
| 101 </if> | 101 </if> |
| 102 <div> | 102 <div> |
| 103 <div class="checkbox"> | 103 <div> |
| 104 <input id="toolbarShowHomeButton" pref="browser.show_home_button" | 104 <label id="home-page-label" for="homepage-select" |
| 105 metric="Options_Homepage_HomeButton" type="checkbox"> | 105 i18n-content="homePage"></label> |
| 106 <label id="home-page-label" for="toolbarShowHomeButton" | 106 <select id="homepage-select"> |
| 107 i18n-content="toolbarShowHomeButton"> | 107 <option value="none" i18n-content="homePageNone"></option> |
| 108 </label> | 108 <option value="ntp" i18n-content="homePageNtp"></option> |
| 109 <button id="change-home-page" i18n-content="changeHomePage" | 109 <option value="url"></option> |
|
csilv
2012/02/01 20:37:29
I think we need to build this menu dynamically. T
Tyler Breisacher (Chromium)
2012/02/01 21:49:38
Currently, it is automatically set to google.com
| |
| 110 class="link-button"></button> | 110 <option value="choose" i18n-content="homePageChoose"></option> |
| 111 </select> | |
| 111 </div> | 112 </div> |
| 112 <div class="checkbox"> | 113 <div class="checkbox"> |
| 113 <label> | 114 <label> |
| 114 <input id="toolbarShowBookmarksBar" | 115 <input id="toolbarShowBookmarksBar" |
| 115 pref="bookmark_bar.show_on_all_tabs" | 116 pref="bookmark_bar.show_on_all_tabs" |
| 116 metric="Options_ShowBookmarksBar" type="checkbox"> | 117 metric="Options_ShowBookmarksBar" type="checkbox"> |
| 117 <span i18n-content="toolbarShowBookmarksBar"></span> | 118 <span i18n-content="toolbarShowBookmarksBar"></span> |
| 118 </label> | 119 </label> |
| 119 </div> | 120 </div> |
| 120 <if expr="not pp_ifdef('toolkit_views') and is_posix and not is_macosx"> | 121 <if expr="not pp_ifdef('toolkit_views') and is_posix and not is_macosx"> |
| (...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 293 </section> | 294 </section> |
| 294 </if> | 295 </if> |
| 295 <section> | 296 <section> |
| 296 <h3 i18n-content="sectionTitleAdvanced"></h3> | 297 <h3 i18n-content="sectionTitleAdvanced"></h3> |
| 297 <div> | 298 <div> |
| 298 <button id="advancedOptionsButton" | 299 <button id="advancedOptionsButton" |
| 299 i18n-content="advancedOptionsButtonTitle"></button> | 300 i18n-content="advancedOptionsButtonTitle"></button> |
| 300 </div> | 301 </div> |
| 301 </section> | 302 </section> |
| 302 </div> | 303 </div> |
| OLD | NEW |
