chrome/browser/resources/options2/home_page_overlay.html - Issue 9296038: [uber] Redoing the homepage selection UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/options2/home_page_overlay.html

Issue 9296038: [uber] Redoing the homepage selection UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: set prefs explicitly when OK clicked Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/app/generated_resources.grd ('K') | « chrome/browser/resources/options2/browser_options.js ('k') | chrome/browser/resources/options2/home_page_overlay.js » ('j') | chrome/browser/resources/options2/home_page_overlay.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div id="home-page-overlay" class="page" hidden>	1 <div id="home-page-overlay" class="page" hidden>

2 <h1 i18n-content="homePageTitle"></h1>	2 <h1 i18n-content="homePageTitle"></h1>

3 <div class="content-area">	3 <div class="content-area">

4 <div class="radio">	4 <div class="hbox stretch box-align-center">

5 <label>	5 <label for="homepageURL" i18n-content="homePageDialogLabel"></label>

6 <input id="homepage-use-ntp" type="radio" name="homepage" value="true"

7 metric="Options_Homepage_IsNewTabPage" pref="homepage_is_newtabpage"

8 dialog-pref>

9 <span i18n-content="homepageUseNewTab">Use the New Tab page</span>

10 </label>

11 </div>

12 <div id="customHomePageGroup">

13 <div class="radio">

14 <label>

15 <input id="homepage-use-url" type="radio" name="homepage"

16 value="false" metric="Options_Homepage_IsNewTabPage"

17 pref="homepage_is_newtabpage" dialog-pref>

18 <span i18n-content="homepageUseURL">Open this page:</span>

19 </label>

20 </div>

21 <input id="homepageURL" type="url"	6 <input id="homepageURL" type="url"

22 class="weakrtl favicon-cell hbox stretch"	7 class="weakrtl favicon-cell hbox stretch"

23 data-type="url" pref="homepage" dialog-pref>	8 data-type="url" pref="homepage" controlled-by="recommended"

	9 dialog-pref>

24 </div>	10 </div>

25 </div>	11 </div>

26 <div class="action-area">	12 <div class="action-area">

27 <div class="button-strip">	13 <div class="button-strip">

28 <button id="home-page-cancel" type="reset" i18n-content="cancel">	14 <button id="home-page-cancel" type="reset" i18n-content="cancel">

29 </button>	15 </button>

30 <button id="home-page-confirm" type="submit" i18n-content="ok"></button>	16 <button id="home-page-confirm" type="submit" i18n-content="ok"></button>

31 </div>	17 </div>

32 </div>	18 </div>

33 </div>	19 </div>

OLD	NEW