Fix WiFi & VPN connection dialogs when controls a disabled through policy.

Fix WiFi & VPN connection dialogs when controls a disabled through policy.

Previously, the UI would make decision based on the enabled() state of
controls, indicating that the control is not relevant for the currently
chosen configuration. This doesn't work for policy-configured networks,
since the control might just be locked down, in which case it is
relevant, but disabled.

BUG=chromium-os:23124
TEST=Configure ONC networks through policy, observe that the connection dialogs show the configured values even though disabled.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119664

[Mattias Nissler (ping if slow), 2012-01-27 15:22:15]

Can you review this?

It's basically some UI massaging for options locked down through policy. I tried
to be extra-careful not to change the non-policy code paths.

[stevenjb, 2012-01-27 19:14:07]

lgtm

http://codereview.chromium.org/9296009/diff/1/chrome/browser/chromeos/options...
File chrome/browser/chromeos/options/wifi_config_view.cc (right):

http://codereview.chromium.org/9296009/diff/1/chrome/browser/chromeos/options...
chrome/browser/chromeos/options/wifi_config_view.cc:937:
passphrase_label_->SetEnabled(wifi);
nit: I'd use (wifi ? true : false) to make it clear that a bool is getting
passed here.

[Mattias Nissler (ping if slow), 2012-01-30 12:56:49]

http://codereview.chromium.org/9296009/diff/1/chrome/browser/chromeos/options...
File chrome/browser/chromeos/options/wifi_config_view.cc (right):

http://codereview.chromium.org/9296009/diff/1/chrome/browser/chromeos/options...
chrome/browser/chromeos/options/wifi_config_view.cc:937:
passphrase_label_->SetEnabled(wifi);
On 2012/01/27 19:14:07, stevenjb (chromium) wrote:
> nit: I'd use (wifi ? true : false) to make it clear that a bool is getting
> passed here.

Switched it to wifi != NULL.