Find correct source position in inlined functions on debug break.

Find correct source position in inlined functions on debug break.

BUG=110010
TEST=test-debug/DebugBreakInline

Committed: https://code.google.com/p/v8/source/detail?r=10551

[Yang, 2012-01-27 14:40:17]

Please take a look.

[Søren Gjesse, 2012-01-30 08:59:28]

lgtm

But please refactor the test to avoid using sleep in a separate CL.

http://codereview.chromium.org/9295014/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/9295014/diff/1/test/cctest/test-debug.cc#newco...
test/cctest/test-debug.cc:7288: 
I think this test could have been written in JavaScript using the native
function %OptimizeFunctionOnNextCall and the JavaScript debugger API. See
mjsunit/debug-break-inline.js. Maybe extend mjsunit/debug-break-inline.js with
line number checking as well.

http://codereview.chromium.org/9295014/diff/1/test/cctest/test-debug.cc#newco...
test/cctest/test-debug.cc:7293: // Wait for crankshaft to inline f() into g();
Having tests with sleeps in then is not a good idea, as they will delay the
running of the tests. Please change the test to first run the code for some
iterations then use %OptimizeFunctionOnNextCall (or make
Runtime_OptimizeFunctionOnNextCall available from C tests) to optimize/inline
it. You can pass the number of iterations to f and have it be relatively small
for the warmup and larger for when you want to use DebugBread from the other
thread.

[Yang, 2012-01-30 12:22:35]

I changed the test according to your suggestions. Please take another look.

[Søren Gjesse, 2012-01-30 12:26:57]

lgtm

http://codereview.chromium.org/9295014/diff/2002/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/9295014/diff/2002/test/cctest/test-debug.cc#ne...
test/cctest/test-debug.cc:7307: // Each frame's source position has to be
different from the previous one.
Maybe put in expected lines

int expected_line[..] = {1, 4, ...}

and check for the actual line

CHECK_EQ(expected_line[i] = result->Int32Value();