Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: sdk/lib/_internal/compiler/js_lib/foreign_helper.dart

Issue 929313002: Use an enum in embedded_names as input to JS_GET_NAME. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/js_lib/foreign_helper.dart
diff --git a/sdk/lib/_internal/compiler/js_lib/foreign_helper.dart b/sdk/lib/_internal/compiler/js_lib/foreign_helper.dart
index 96fd0a56cba7020bec187ef598802574bc4f5b72..8a400f82bf2496bb4771caec3c984b9aeceb24f7 100644
--- a/sdk/lib/_internal/compiler/js_lib/foreign_helper.dart
+++ b/sdk/lib/_internal/compiler/js_lib/foreign_helper.dart
@@ -4,6 +4,8 @@
library _foreign_helper;
+import 'dart:_js_embedded_names' show JsGetName;
+
/**
* Emits a JavaScript code fragment parameterized by arguments.
*
@@ -240,7 +242,7 @@ String JS_FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG() {}
String JS_FUNCTION_TYPE_NAMED_PARAMETERS_TAG() {}
/// Returns the JS name for [name] from the Namer.
-String JS_GET_NAME(String name) {}
+String JS_GET_NAME(JsGetName name) {}
/// Reads an embedded global.
///

Powered by Google App Engine
This is Rietveld 408576698