Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(1306)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: tests/language/src/Factory2NegativeTest.dart
Issue
9290065
:
Simplify parsing of 'new' operator. (Closed)
Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Simplify parsing of 'new' operator
Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
runtime/vm/class_finalizer.cc
runtime/vm/parser.h
runtime/vm/parser.cc
tests/language/src/Factory2NegativeTest.dart
tests/language/src/Factory3NegativeTest.dart
tests/language/src/Factory4Test.dart
tests/language/src/FactoryNegativeTest.dart
tests/language/src/FunctionTypeAliasTest.dart
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« runtime/vm/parser.cc
('k') |
tests/language/src/Factory3NegativeTest.dart »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2
// for details. All rights reserved. Use of this source code is governed by a
3
// BSD-style license that can be found in the LICENSE file.
4
5
// Test compile time error for factories with parameterized types.
6
7
interface Link<T> default LinkFactory {
8
Link.create();
9
}
10
11
class LinkFactory { // Compile time error: should be LinkFactory<T> to match i nterface above
12
factory Link.create() {
13
return null;
14
}
15
}
16
17
main() {
18
var a = new Link.create(); // Equivalent to new Link<Dynamic>.create().
19
}
OLD
NEW
« no previous file with comments
|
« runtime/vm/parser.cc
('k') |
tests/language/src/Factory3NegativeTest.dart »
('j') |
no next file with comments »
Issue 9290065: Simplify parsing of 'new' operator. (Closed)
Created 8 years, 10 months ago by regis
Modified 8 years, 10 months ago
Reviewers: hausner, srdjan
Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Comments: 10
This is Rietveld
408576698