Issue 9290044: Fix intermittent stack overflow in Hydrogen code generation in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9290044: Fix intermittent stack overflow in Hydrogen code generation in tests. (Closed)

Created:
8 years, 11 months ago by Erik Corry

Modified:
8 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix intermittent stack overflow in Hydrogen code generation in tests. Committed: https://code.google.com/p/v8/source/detail?r=10511

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	src/hydrogen.h	View		1 chunk	+7 lines, -3 lines	1 comment	Download
	M	src/hydrogen.cc	View		3 chunks	+6 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

8 years, 11 months ago (2012-01-26 10:42:56 UTC) #2

lgtm

http://codereview.chromium.org/9290044/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/9290044/diff/1/src/hydrogen.cc#newcode4801
src/hydrogen.cc:4801: if ((FLAG_limit_inlining && target->shared()->SourceSize()
> kSmallMaxSourceSize) ||
long line

http://codereview.chromium.org/9290044/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

http://codereview.chromium.org/9290044/diff/1/src/hydrogen.h#newcode776
src/hydrogen.h:776: static const int kBigMaxInlinedNodes = 1000;
big vs. small is a bit confusing. it's limited/unlimited.

Expand Messages | Collapse Messages