When preparing heap for breakpoints make sure not to recompile inlined functions.

When preparing heap for breakpoints make sure not to flush away non-optimized code for inlined functions.

Debug::PrepareForBreakPoints was not fully populating active_functions list.

R=erik.corry@gmail.com
TEST=test/mjsunit/regress/regress-debug-code-recompilation.js

Committed: https://code.google.com/p/v8/source/detail?r=10503

[Erik Corry, 2012-01-25 14:05:28]

LGTM

https://chromiumcodereview.appspot.com/9290013/diff/1/src/debug.cc
File src/debug.cc (right):

https://chromiumcodereview.appspot.com/9290013/diff/1/src/debug.cc#newcode1783
src/debug.cc:1783: Object* active_code_marker =
isolate_->heap()->the_hole_value();
It seems we only go through the stack for the current thread, leaving the other
threads to crash, but lets fix that in a different change.

https://chromiumcodereview.appspot.com/9290013/diff/1/src/debug.cc#newcode1807
src/debug.cc:1807: // Scan the heap for all non-optimized functions which has no
has -> have

https://chromiumcodereview.appspot.com/9290013/diff/1/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-debug-code-recompilation.js (right):

https://chromiumcodereview.appspot.com/9290013/diff/1/test/mjsunit/regress/re...
test/mjsunit/regress/regress-debug-code-recompilation.js:36: }
The test does not seem to test having anything on the stack when breakpoints are
activated.

[Erik Corry, 2012-01-25 15:00:56]

LGTM

https://chromiumcodereview.appspot.com/9290013/diff/1007/src/debug.cc
File src/debug.cc (right):

https://chromiumcodereview.appspot.com/9290013/diff/1007/src/debug.cc#newcode...
src/debug.cc:1843: frame_code->instruction_size(),
Can we indent lines like this so that we have only the start of a new argument
to PrintF at this indentation level?

https://chromiumcodereview.appspot.com/9290013/diff/1007/src/debug.cc#newcode...
src/debug.cc:1904: Object* active_code_marker =
isolate_->heap()->the_hole_value();
I know the hole never moves or dies, but it seems a bit gratuitous to do this
before the call the CollectAllGarbage.