Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: frog/member_set.dart

Issue 9290007: Fixes isolate issue #1329 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merged Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/tests/client/client.status ('k') | frog/minfrog » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/member_set.dart
diff --git a/frog/member_set.dart b/frog/member_set.dart
index 5912f54ca7b07237929eff507100f40fc36f12ef..0e0f2ef119bcba3daeadb01bc451bcc57e53b7b9 100644
--- a/frog/member_set.dart
+++ b/frog/member_set.dart
@@ -264,6 +264,16 @@ class InvokeKey {
if (!(member.parameters.length == bareArgs && namedArgs == null)) {
needsVarCall = true;
}
+ // TODO(jimhug): Egregious hack for isolates + DOM - see
+ // Value._maybeWrapFunction for more details.
+ if (member.library == world.dom) {
+ for (var p in member.parameters) {
+ if (p.type.getCallMethod() != null) {
+ needsVarCall = true;
+ }
+ }
+ }
+
// TODO(jimhug): Should create a less specific version of args.
if (member.canInvoke(context, args)) {
if (member.isMethod) {
« no previous file with comments | « client/tests/client/client.status ('k') | frog/minfrog » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698