Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9290006: Reverting r3585. Unclear how this broke dartc... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/tools/buildbot_annotated_steps.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 3587)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -470,15 +470,14 @@
String executable = getFilename(dumpRenderTreeFilename);
List<String> args;
if (component == 'webdriver') {
- executable = 'python';
+ executable = '$dartDir/tools/testing/run_selenium.py';
if (new Platform().operatingSystem() == 'windows') {
// For Windows, the first command, must have the Windows
// slash direction.
// TODO(efortuna): Get rid of this hack when issue 1306 is fixed.
executable = executable.replaceAll('/', '\\');
}
- args = ['$dartDir/tools/testing/run_selenium.py', '--out=$htmlPath',
- '--browser=${configuration["browser"]}'];
+ args = ['--out=$htmlPath', '--browser=${configuration["browser"]}'];
} else {
args = ['--no-timeout'];
if (component == 'dartium') {
@@ -900,43 +899,35 @@
class TestUtils {
- static String executableSuffix(String component) {
- if (new Platform().operatingSystem() == 'windows') {
- if (component != 'frogium' && component != 'webdriver') {
- return '.exe';
- } else {
- return '.bat';
- }
- }
- return '';
- }
+ static String get executableSuffix() =>
+ (new Platform().operatingSystem() == 'windows') ? '.exe' : '';
static String executableName(Map configuration) {
- String suffix = executableSuffix(configuration['component']);
+ String postfix = executableSuffix;
switch (configuration['component']) {
case 'vm':
- return 'dart$suffix';
+ return 'dart$postfix';
case 'dartc':
- return 'compiler/bin/dartc_test$suffix';
+ return 'compiler/bin/dartc_test$postfix';
case 'frog':
case 'leg':
- return 'frog/bin/frog$suffix';
+ return 'frog/bin/frog$postfix';
case 'frogsh':
- return 'frog/bin/frogsh$suffix';
+ return 'frog/bin/frogsh';
default:
throw "Unknown executable for: ${configuration['component']}";
}
}
static String compilerName(Map configuration) {
- String suffix = executableSuffix(configuration['component']);
+ String postfix = executableSuffix;
switch (configuration['component']) {
case 'chromium':
case 'dartc':
- return 'compiler/bin/dartc$suffix';
+ return 'compiler/bin/dartc$postfix';
case 'frogium':
case 'webdriver':
- return 'frog/bin/frogsh$suffix';
+ return 'frog/bin/frogsh';
default:
throw "Unknown compiler for: ${configuration['component']}";
}
« no previous file with comments | « client/tools/buildbot_annotated_steps.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698