Reverting r3585. Unclear how this broke dartc...

tools/testing/dart/test_suite.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("test_suite");
 
 #import("dart:io");
 #import("status_file_parser.dart");
 #import("test_runner.dart");
 #import("multitest.dart");
@@ skipping 452 matching lines @@
           compilerExecutable = null;
           compilerArgs = null;
           break;
         default:
           Expect.fail('unimplemented component $component');
       }
 
       String executable = getFilename(dumpRenderTreeFilename);
       List<String> args;
       if (component == 'webdriver') {
-        executable = 'python';
+        executable = '$dartDir/tools/testing/run_selenium.py';
         if (new Platform().operatingSystem() == 'windows') {
           // For Windows, the first command, must have the Windows 
           // slash direction.
           // TODO(efortuna): Get rid of this hack when issue 1306 is fixed.
           executable = executable.replaceAll('/', '\\');
         }
-        args = ['$dartDir/tools/testing/run_selenium.py', '--out=$htmlPath', 
-            '--browser=${configuration["browser"]}'];
+        args = ['--out=$htmlPath', '--browser=${configuration["browser"]}'];
       } else {
         args = ['--no-timeout'];
         if (component == 'dartium') {
           var dartFlags = ['--ignore-unrecognized-flags'];
           if (configuration["checked"]) {
             dartFlags.add('--enable_asserts');
             dartFlags.add("--enable_type_checks");
           }
           dartFlags.addAll(vmOptions);
           args.add('--dart-flags=${Strings.join(dartFlags, " ")}');
@@ skipping 401 matching lines @@
          '$dartDir/third_party/hamcrest/v1_3/hamcrest-generator-1.3.0RC2.jar',
          '$dartDir/third_party/hamcrest/v1_3/hamcrest-integration-1.3.0RC2.jar',
          '$dartDir/third_party/hamcrest/v1_3/hamcrest-library-1.3.0RC2.jar',
          '$dartDir/third_party/junit/v4_8_2/junit.jar'],
         ':');  // Path separator.
   }
 }
 
 
 class TestUtils {
-  static String executableSuffix(String component) {
-    if (new Platform().operatingSystem() == 'windows') {
-      if (component != 'frogium' && component != 'webdriver') {
-        return '.exe';
-      } else {
-        return '.bat';
-      }
-    }
-    return '';
-  }
+  static String get executableSuffix() =>
+      (new Platform().operatingSystem() == 'windows') ? '.exe' : '';
 
   static String executableName(Map configuration) {
-    String suffix = executableSuffix(configuration['component']);
+    String postfix = executableSuffix;
     switch (configuration['component']) {
       case 'vm':
-        return 'dart$suffix';
+        return 'dart$postfix';
       case 'dartc':
-        return 'compiler/bin/dartc_test$suffix';
+        return 'compiler/bin/dartc_test$postfix';
       case 'frog':
       case 'leg':
-          return 'frog/bin/frog$suffix';
+          return 'frog/bin/frog$postfix';
       case 'frogsh':
-        return 'frog/bin/frogsh$suffix';
+        return 'frog/bin/frogsh';
       default:
         throw "Unknown executable for: ${configuration['component']}";
     }
   }
 
   static String compilerName(Map configuration) {
-    String suffix = executableSuffix(configuration['component']);
+    String postfix = executableSuffix;
     switch (configuration['component']) {
       case 'chromium':
       case 'dartc':
-        return 'compiler/bin/dartc$suffix';
+        return 'compiler/bin/dartc$postfix';
       case 'frogium':
       case 'webdriver':
-        return 'frog/bin/frogsh$suffix';
+        return 'frog/bin/frogsh';
       default:
         throw "Unknown compiler for: ${configuration['component']}";
     }
   }
 
   static String dartShellFileName(Map configuration) {
     var name = '${buildDir(configuration)}/${executableName(configuration)}';
     if (!(new File(name)).existsSync()) {
       throw "Executable '$name' does not exist";
     }
@@ skipping 108 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }