Changing manifest to v2 extension samples

Changing manifest to v2 in extension samples

Patch from Ernest Delgado <ernestd@chromium.org>;.

BUG=111049
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119883

[Mike West, 2012-01-26 22:16:33]

http://codereview.chromium.org/9289057/diff/1/chrome/common/extensions/docs/e...
File chrome/common/extensions/docs/examples/api/cookies/manager.js (right):

http://codereview.chromium.org/9289057/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/examples/api/cookies/manager.js:252:
document.querySelector('#filter_div button').addEventListener('click',
resetFilter);
80+ chars (which you already know).

You'll need to throw these event listeners into the `DOMContentLoaded` handler
as well. Otherwise the elements won't actually exist when the code is executed.

[Mike West, 2012-01-27 16:06:32]

LGTM with nits.

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
File chrome/common/extensions/docs/examples/api/idle/idle_simple/history.js
(right):

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/idle/idle_simple/history.js:58:
window.setInterval(checkState, 1000);
You'll need to pull these out into a DOMContentLoaded handler.

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/idle/idle_simple/history.js:77:
window.setInterval(renderHistory, 1000);
These too.

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
File chrome/common/extensions/docs/examples/api/infobars/sandwichbar/infobar.js
(right):

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/infobars/sandwichbar/infobar.js:1: //
Obtain the count of sandwiches from the page URL.
Needs a copyright notice.

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
File chrome/common/extensions/docs/examples/api/messaging/timer/popup.js
(right):

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/messaging/timer/popup.js:1: if
(!chrome.benchmarking) {
Copyright.

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
File
chrome/common/extensions/docs/examples/api/processes/process_monitor/popup.js
(right):

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/processes/process_monitor/popup.js:1:
// Shows an updating list of process statistics.
Copyright.

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
File chrome/common/extensions/docs/examples/api/tabs/inspector/tabs_api.js
(right):

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/tabs/inspector/tabs_api.js:1: tabs =
{};
Copyright.

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
File chrome/common/extensions/docs/examples/apps/background-simple/index.js
(right):

http://codereview.chromium.org/9289057/diff/11001/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/apps/background-simple/index.js:1: //
Check for support
Copyright.

[Mike West, 2012-01-29 16:57:02]

+adam, FYI.

LGTM (again). Can you rebuild/zip the documentation so we can get this landed?

You'll need to build DumpRenderTree, and then run
`chrome/common/extensions/docs/build/build.py --page-name samples`. If that
turns into a problem, I can zip the files for you. :)

[Mike West, 2012-01-29 17:17:37]

Actually, on third glance, I'm a little surprised that so many of the extensions
are just manifest.json changes. I'd expected otherwise... Have you tested the
extensions?

Don't get me wrong, I'm thrilled if it's the case. I'm just surprised. :)

[abarth-chromium, 2012-01-29 19:24:04]

Silly nit below

http://codereview.chromium.org/9289057/diff/10043/chrome/common/extensions/do...
File
chrome/common/extensions/docs/examples/api/debugger/pause-resume/background.js
(right):

http://codereview.chromium.org/9289057/diff/10043/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/debugger/pause-resume/background.js:1:
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
Why update the copyright year?  There aren't any changes to this file.

[Mike West, 2012-01-31 05:25:22]

Alright, this looks good to me, thanks Ernest! I'll throw this into the commit
queue for you.

[commit-bot: I haz the power, 2012-01-31 05:25:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernestd@chromium.org/9289057/18001

[commit-bot: I haz the power, 2012-01-31 05:25:53]

Can't apply patch for file
chrome/common/extensions/docs/examples/api/cookies/manager.js.
While running patch -p1 --forward --force;
patching file chrome/common/extensions/docs/examples/api/cookies/manager.js
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 155.
Hunk #3 FAILED at 269.
3 out of 3 hunks FAILED -- saving rejects to file
chrome/common/extensions/docs/examples/api/cookies/manager.js.rej

[Mike West, 2012-01-31 08:26:40]

Thanks Ernest, trying CQ again.

[commit-bot: I haz the power, 2012-01-31 08:26:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernestd@chromium.org/9289057/21002

[commit-bot: I haz the power, 2012-01-31 08:27:13]

Can't apply patch for file
chrome/common/extensions/docs/examples/api/cookies/manager.js.
While running patch -p1 --forward --force;
patching file chrome/common/extensions/docs/examples/api/cookies/manager.js
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 155.
Hunk #3 FAILED at 269.
3 out of 3 hunks FAILED -- saving rejects to file
chrome/common/extensions/docs/examples/api/cookies/manager.js.rej

[Mike West, 2012-01-31 08:31:08]

Bah. Don't know why this isn't working. Pulling the patch down locally, I'm
getting conflicts all over the place.

I'll just resolve them locally and land the patch for you, Ernest. Might even
make M18. ;)

[Mike West, 2012-01-31 10:39:56]

Landed this. Thanks for doing the work, Ernest!

[Mike West, 2012-01-31 10:43:53]

On 2012/01/31 10:39:56, Mike West (chromium) wrote:
> Landed this. Thanks for doing the work, Ernest!

Filed http://crbug.com/112071 to request permission to merge back to M18 once
the branch is made (I assume we missed the cut by a few hours).