Adding GpuMemoryManager to track GpuCommandBufferStub visibility and last_used_time and dictate mem…

content/common/gpu/gpu_command_buffer_stub.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_GPU_GPU_COMMAND_BUFFER_STUB_H_
 #define CONTENT_COMMON_GPU_GPU_COMMAND_BUFFER_STUB_H_
 #pragma once
 
 #if defined(ENABLE_GPU)
 
@@ skipping 15 matching lines @@
 #include "ui/gfx/native_widget_types.h"
 #include "ui/gfx/size.h"
 #include "ui/gfx/surface/transport_dib.h"
 
 #if defined(OS_MACOSX)
 #include "ui/gfx/surface/accelerated_surface_mac.h"
 #endif
 
 class GpuChannel;
 class GpuWatchdog;
+class GpuMemoryAllocation;
 
 class GpuCommandBufferStub
     : public IPC::Channel::Listener,
       public IPC::Message::Sender,
       public base::SupportsWeakPtr<GpuCommandBufferStub> {
  public:
   GpuCommandBufferStub(
       GpuChannel* channel,
       GpuCommandBufferStub* share_group,
       gfx::PluginWindowHandle handle,
@@ skipping 20 matching lines @@
 
   // Whether this command buffer needs to be polled again in the future.
   bool HasMoreWork();
 
   // Set the swap interval according to the command line.
   void SetSwapInterval();
 
   gpu::gles2::GLES2Decoder* decoder() const { return decoder_.get(); }
   gpu::GpuScheduler* scheduler() const { return scheduler_.get(); }
 
+  // visibility state of associated render widgets.

[nduca, 2012/01/27 10:10:13]

Visibility, upper cap

+  // Note: This is only valid once last_used_time is != kUnknownLastUsedTime
+  bool visible() const { return visible_; }

[nduca, 2012/01/27 10:10:13]

Please make a visibility_known accessor and update comment accordingly so that
this validity is encoded in the accessor rather than a doc. Make visible() fail
(i forget the chorme equivalent of ASSERT_NOT_REACHED if its unknown.)

+
+  // last_used_time is updated during visibility changes, and can be used for

[nduca, 2012/01/27 10:10:13]

// Comments are sentences and thus the first word is capitalized.

:)

+  // LRU ordering in combination with visibility state

[nduca, 2012/01/27 10:10:13]

Not sure the lru comment is useful here.

Why are you using int64 instead of base::TimeTicks?

[mmocny, 2012/01/27 19:51:33]

For no good reason whatsoever.  Changed, thanks.
On 2012/01/27 10:10:13, nduca wrote:

+  static const int64 kUnknownLastUsedTime = 0;
+  int64 last_used_time() const { return last_used_time_; }
+
   // Identifies the target surface.
   int32 surface_id() const { return surface_id_; }
 
   // Identifies the various GpuCommandBufferStubs in the GPU process belonging
   // to the same renderer process.
   int32 route_id() const { return route_id_; }
 
+  // Return the ids of RenderWidgets which have identified as using this stub
+  std::vector<int> render_widget_ids() const;

[nduca, 2012/01/27 10:10:13]

Consistency!

affected_render_widget_ids.

Then you dont need a comment since its obvious

+
   gfx::GpuPreference gpu_preference() { return gpu_preference_; }
 
   // Sends a message to the console.
   void SendConsoleMessage(int32 id, const std::string& message);
 
+  void SetMemoryAllocation(GpuMemoryAllocation const& allocation);

[nduca, 2012/01/27 10:10:13]

This sends not sets, right? Call things by what they do.

+
  private:
   void Destroy();
 
   // Cleans up and sends reply if OnInitialize failed.
   void OnInitializeFailed(IPC::Message* reply_message);
 
   // Message handlers:
   void OnInitialize(IPC::Message* reply_message);
   void OnSetGetBuffer(int32 shm_id, IPC::Message* reply_message);
   void OnSetParent(int32 parent_route_id,
@@ skipping 36 matching lines @@
 
   gfx::PluginWindowHandle handle_;
   gfx::Size initial_size_;
   gpu::gles2::DisallowedFeatures disallowed_features_;
   std::string allowed_extensions_;
   std::vector<int32> requested_attribs_;
   gfx::GpuPreference gpu_preference_;
   int32 route_id_;
   bool software_;
   uint32 last_flush_count_;
+  bool visible_;
+  int64 last_used_time_;
 
   // Identifies the window for the rendering results on the browser side.
   int32 surface_id_;
 
   scoped_ptr<gpu::CommandBufferService> command_buffer_;
   scoped_ptr<gpu::gles2::GLES2Decoder> decoder_;
   scoped_ptr<gpu::GpuScheduler> scheduler_;
   scoped_refptr<gfx::GLContext> context_;
   scoped_refptr<gfx::GLSurface> surface_;
 
   // SetParent may be called before Initialize, in which case we need to keep
   // around the parent stub, so that Initialize can set the parent correctly.
   base::WeakPtr<GpuCommandBufferStub> parent_stub_for_initialization_;
   uint32 parent_texture_for_initialization_;
 
   GpuWatchdog* watchdog_;
 
   // Zero or more video decoders owned by this stub, keyed by their
   // decoder_route_id.
   IDMap<GpuVideoDecodeAccelerator, IDMapOwnPointer> video_decoders_;
 
   DISALLOW_COPY_AND_ASSIGN(GpuCommandBufferStub);
 };
 
 #endif  // defined(ENABLE_GPU)
 
 #endif  // CONTENT_COMMON_GPU_GPU_COMMAND_BUFFER_STUB_H_