Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: ui/gfx/compositor/layer_unittest.cc

Issue 9289036: aura: Add Layer::LAYER_SOLID_COLOR to compositor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: minor changes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/compositor/layer_unittest.cc
diff --git a/ui/gfx/compositor/layer_unittest.cc b/ui/gfx/compositor/layer_unittest.cc
index 01406604ecc02c6875dff80c8506396f52429b20..2b9fabf4c00d43872b107eceef8cbc2ad050fa3d 100644
--- a/ui/gfx/compositor/layer_unittest.cc
+++ b/ui/gfx/compositor/layer_unittest.cc
@@ -122,7 +122,7 @@ std::string GetLayerChildrenNames(const Layer& layer) {
class ColoredLayer : public Layer, public LayerDelegate {
public:
explicit ColoredLayer(SkColor color)
- : Layer(Layer::LAYER_HAS_TEXTURE),
+ : Layer(Layer::LAYER_TEXTURED),
color_(color) {
set_delegate(this);
}
@@ -177,7 +177,7 @@ class LayerWithRealCompositorTest : public testing::Test {
}
Layer* CreateNoTextureLayer(const gfx::Rect& bounds) {
- Layer* layer = CreateLayer(Layer::LAYER_HAS_NO_TEXTURE);
+ Layer* layer = CreateLayer(Layer::LAYER_NOT_DRAWN);
layer->SetBounds(bounds);
return layer;
}
@@ -391,7 +391,7 @@ class LayerWithDelegateTest : public testing::Test, public CompositorDelegate {
}
virtual Layer* CreateNoTextureLayer(const gfx::Rect& bounds) {
- Layer* layer = CreateLayer(Layer::LAYER_HAS_NO_TEXTURE);
+ Layer* layer = CreateLayer(Layer::LAYER_NOT_DRAWN);
layer->SetBounds(bounds);
return layer;
}
@@ -597,13 +597,13 @@ class LayerWithNullDelegateTest : public LayerWithDelegateTest {
}
Layer* CreateTextureLayer(const gfx::Rect& bounds) {
- Layer* layer = CreateLayer(Layer::LAYER_HAS_TEXTURE);
+ Layer* layer = CreateLayer(Layer::LAYER_TEXTURED);
layer->SetBounds(bounds);
return layer;
}
Layer* CreateNoTextureLayer(const gfx::Rect& bounds) OVERRIDE {
- Layer* layer = CreateLayer(Layer::LAYER_HAS_NO_TEXTURE);
+ Layer* layer = CreateLayer(Layer::LAYER_NOT_DRAWN);
layer->SetBounds(bounds);
return layer;
}
@@ -968,11 +968,11 @@ TEST_F(LayerWithNullDelegateTest,
// +- L122 (texture)
TEST_F(LayerWithNullDelegateTest,
NOT_APPLICABLE_TO_WEBKIT_COMPOSITOR(NoCompositor)) {
- scoped_ptr<Layer> l1(CreateLayer(Layer::LAYER_HAS_NO_TEXTURE));
- scoped_ptr<Layer> l11(CreateLayer(Layer::LAYER_HAS_TEXTURE));
- scoped_ptr<Layer> l12(CreateLayer(Layer::LAYER_HAS_NO_TEXTURE));
- scoped_ptr<Layer> l121(CreateLayer(Layer::LAYER_HAS_TEXTURE));
- scoped_ptr<Layer> l122(CreateLayer(Layer::LAYER_HAS_TEXTURE));
+ scoped_ptr<Layer> l1(CreateLayer(Layer::LAYER_NOT_DRAWN));
+ scoped_ptr<Layer> l11(CreateLayer(Layer::LAYER_TEXTURED));
+ scoped_ptr<Layer> l12(CreateLayer(Layer::LAYER_NOT_DRAWN));
+ scoped_ptr<Layer> l121(CreateLayer(Layer::LAYER_TEXTURED));
+ scoped_ptr<Layer> l122(CreateLayer(Layer::LAYER_TEXTURED));
EXPECT_EQ(NULL, l1->texture());
EXPECT_EQ(NULL, l11->texture());
@@ -990,7 +990,7 @@ TEST_F(LayerWithNullDelegateTest,
EXPECT_EQ(NULL, l1->texture());
- // Despite having type LAYER_HAS_TEXTURE, l11 will not have one set yet
+ // Despite having type LAYER_TEXTURED, l11 will not have one set yet
// because it has never been asked to draw.
EXPECT_EQ(NULL, l11->texture());
@@ -1023,9 +1023,9 @@ TEST_F(LayerWithNullDelegateTest,
// Various visibile/drawn assertions.
TEST_F(LayerWithNullDelegateTest, Visibility) {
- scoped_ptr<Layer> l1(new Layer(Layer::LAYER_HAS_TEXTURE));
- scoped_ptr<Layer> l2(new Layer(Layer::LAYER_HAS_TEXTURE));
- scoped_ptr<Layer> l3(new Layer(Layer::LAYER_HAS_TEXTURE));
+ scoped_ptr<Layer> l1(new Layer(Layer::LAYER_TEXTURED));
+ scoped_ptr<Layer> l2(new Layer(Layer::LAYER_TEXTURED));
+ scoped_ptr<Layer> l3(new Layer(Layer::LAYER_TEXTURED));
l1->Add(l2.get());
l2->Add(l3.get());
@@ -1075,10 +1075,10 @@ TEST_F(LayerWithNullDelegateTest, Visibility) {
// Checks that stacking-related methods behave as advertised.
TEST_F(LayerWithNullDelegateTest, Stacking) {
- scoped_ptr<Layer> root(new Layer(Layer::LAYER_HAS_NO_TEXTURE));
- scoped_ptr<Layer> l1(new Layer(Layer::LAYER_HAS_TEXTURE));
- scoped_ptr<Layer> l2(new Layer(Layer::LAYER_HAS_TEXTURE));
- scoped_ptr<Layer> l3(new Layer(Layer::LAYER_HAS_TEXTURE));
+ scoped_ptr<Layer> root(new Layer(Layer::LAYER_NOT_DRAWN));
+ scoped_ptr<Layer> l1(new Layer(Layer::LAYER_TEXTURED));
+ scoped_ptr<Layer> l2(new Layer(Layer::LAYER_TEXTURED));
+ scoped_ptr<Layer> l3(new Layer(Layer::LAYER_TEXTURED));
l1->set_name("1");
l2->set_name("2");
l3->set_name("3");

Powered by Google App Engine
This is Rietveld 408576698