chrome/browser/resources/omnibox/omnibox.html - Issue 9289028: Make chrome://omnibox/ be able to report per-provider matches.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/omnibox/omnibox.html

Issue 9289028: Make chrome://omnibox/ be able to report per-provider matches. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: createTextNode -> textContent Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>Omnibox Debug Page</title>	5 <title>Omnibox Debug Page</title>

6 <link rel="stylesheet" href="omnibox.css">	6 <link rel="stylesheet" href="omnibox.css">

7 <script src="chrome://resources/js/cr.js"></script>	7 <script src="chrome://resources/js/cr.js"></script>

8 <script src="omnibox.js"></script>	8 <script src="omnibox.js"></script>

9 </head>	9 </head>

10 <body>	10 <body>

11 <div class="input-section">	11 <div class="input-section">

12 <form id="omnibox-input-form" action="">	12 <form id="omnibox-input-form" action="">

13 <p>	13 <p>

14 Enter omnibox input text:	14 Enter omnibox input text:

15 <input id="input-text" type="text" size="40" autofocus>	15 <input id="input-text" type="text" size="40" autofocus>

16 <input type="submit">	16 <input type="submit">

17 </p>	17 </p>

18 <p>	18 <div id="omnibox-input-form-options">
	arv (Not doing code reviews) 2012/01/31 20:29:05 This is kind of ugly. I'm sorry I lead you down th This is kind of ugly. I'm sorry I lead you down this path Mark P 2012/01/31 20:55:34 Do you want me to go back to registering three lis Show quoted text On 2012/01/31 20:29:05, arv wrote: > This is kind of ugly. I'm sorry I lead you down this path Do you want me to go back to registering three listeners? I don't care much either way. arv (Not doing code reviews) 2012/01/31 20:59:35 Yeah, js should adjust to dom, not the other way a Show quoted text On 2012/01/31 20:55:34, Mark P wrote: > On 2012/01/31 20:29:05, arv wrote: > > This is kind of ugly. I'm sorry I lead you down this path > > Do you want me to go back to registering three listeners? > > I don't care much either way. Yeah, js should adjust to dom, not the other way around. Mark P 2012/01/31 21:14:43 Switched back. Show quoted text On 2012/01/31 20:59:35, arv wrote: > On 2012/01/31 20:55:34, Mark P wrote: > > On 2012/01/31 20:29:05, arv wrote: > > > This is kind of ugly. I'm sorry I lead you down this path > > > > Do you want me to go back to registering three listeners? > > > > I don't care much either way. > > Yeah, js should adjust to dom, not the other way around. Switched back.
19 <label>	19 <p>

20 <input id="show-incomplete-results" type="checkbox">	20 <label>

21 Show incomplete results	21 <input id="show-incomplete-results" type="checkbox">

22 </label>	22 Show incomplete results

23 </p>	23 </label>

24 <p>	24 </p>

25 <label>	25 <p>

26 <input id="show-details" type="checkbox">	26 <label>

27 Show all details	27 <input id="show-details" type="checkbox">

28 </label>	28 Show all details

29 </p>	29 </label>

	30 </p>

	31 <p>

	32 <label>

	33 <input id="show-all-providers" type="checkbox">

	34 Show results per provider, not just merged results

	35 </label>

	36 </p>

	37 </div>

30 </form>	38 </form>

31 </div>	39 </div>

32 <div id="omnibox-debug-text"></div>	40 <div id="omnibox-debug-text"></div>

33 </body>	41 </body>

34 </html>	42 </html>

OLD	NEW

« no previous file with comments | « chrome/browser/autocomplete/autocomplete.h ('k') | chrome/browser/resources/omnibox/omnibox.js » ('j') | chrome/browser/resources/omnibox/omnibox.js » ('J')