Make chrome://omnibox/ be able to report per-provider matches.

chrome/browser/autocomplete/autocomplete.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_
 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 158 matching lines @@
 //     on how many times the URL for the Extension App has been typed and how
 //     many of the letters match.
 
 class AutocompleteController;
 class AutocompleteControllerDelegate;
 class AutocompleteInput;
 struct AutocompleteMatch;
 class AutocompleteProvider;
 class AutocompleteResult;
 class KeywordProvider;
+class OmniboxUIHandler;
 class Profile;
 class SearchProvider;
 class TemplateURL;
 
 typedef std::vector<AutocompleteMatch> ACMatches;
 typedef std::vector<AutocompleteProvider*> ACProviders;
 
 // AutocompleteInput ----------------------------------------------------------
 
 // The user input for an autocomplete query.  Allows copying.
@@ skipping 539 matching lines @@
 
   // True if a query is not currently running.
   bool done_;
 
   // Are we in Start()? This is used to avoid updating |result_| and sending
   // notifications until Start() has been invoked on all providers.
   bool in_start_;
 
   Profile* profile_;
 
+  friend class OmniboxUIHandler;  // to provide access to providers_

[Peter Kasting, 2012/01/26 00:19:29]

Nit: List friends atop the private: section.

It might be better in this case to go ahead and expose a getter.  I'm not
obsessed with keeping |providers_| secret.

[Mark P, 2012/01/26 22:11:59]

Okay, created a providers() getter; removed the friend declaration.

I made const ACProviders*.  (I don't want it to return a const ACProviders
itself because that would make a copy.)  If you want me to make it return a
const ACProviders& instead, I can easily do that.

+
   DISALLOW_COPY_AND_ASSIGN(AutocompleteController);
 };
 
 // AutocompleteLog ------------------------------------------------------------
 
 // The data to log (via the metrics service) when the user selects an item
 // from the omnibox popup.
 struct AutocompleteLog {
   AutocompleteLog(const string16& text,
                   AutocompleteInput::Type input_type,
@@ skipping 17 matching lines @@
   // ID of the tab the selected autocomplete suggestion was opened in.
   // Set to -1 if we haven't yet determined the destination tab.
   SessionID::id_type tab_id;
   // Inline autocompleted length (if displayed).
   size_t inline_autocompleted_length;
   // Result set.
   const AutocompleteResult& result;
 };
 
 #endif  // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_