Bring about:credits up to date.

Bring about:credits up to date.

BUG=
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119924

[jbauman, 2012-01-26 21:59:23]

I want to add SwiftShader's license information to this, so I figure I might as
well bring it up to date beforehand.

[Mark Larson, 2012-01-27 20:37:31]

When I try to view the side by side changes, I get an error. That probably
doesn't matter because there's so much churn here.

There are some things that are still in DEPS or some third_party directory that
seem to be dropped in this change:
* Google Toolbox for Mac
* ICU
* pdfsqueeze
* SQLite
* XULRunner SDK
* Strongtalk (this comes from V8)

[jbauman, 2012-01-27 21:13:47]

On 2012/01/27 20:37:31, Mark Larson wrote:
> When I try to view the side by side changes, I get an error. That probably
> doesn't matter because there's so much churn here.

Weird. It was working right after I uploaded, so apparently rietveld broke
later.
> 
> There are some things that are still in DEPS or some third_party directory
that
> seem to be dropped in this change:
> * Google Toolbox for Mac
> * ICU
> * pdfsqueeze
> * SQLite
> * XULRunner SDK
> * Strongtalk (this comes from V8)

SQLite doesn't seem to have a real license, because it's public domain. Should I
just add the old text back in, or leave it out? Also, do you know if Strongtalk
and ICU were ever handled automatically by the script, or were they added
manually to the file?

[Mark Larson, 2012-01-30 04:11:33]

On Fri, Jan 27, 2012 at 13:13, <jbauman@chromium.org> wrote:

>
>> There are some things that are still in DEPS or some third_party directory
>>
> that
>
>> seem to be dropped in this change:
>> * Google Toolbox for Mac
>> * ICU
>> * pdfsqueeze
>> * SQLite
>> * XULRunner SDK
>> * Strongtalk (this comes from V8)
>>
>
> SQLite doesn't seem to have a real license, because it's public domain.
> Should I
> just add the old text back in, or leave it out? Also, do you know if
> Strongtalk
> and ICU were ever handled automatically by the script, or were they added
> manually to the file?
>

The SQLite license was manually created a while ago by evanm and dropped by
shess in an update. We just need to add it back.

The ICU license was similarly dropped in a 4.2 -> 4.6 transition. It's just
a matter of, ironically, adding a plaintext version of
deps/third_party/icu46/license.html as LICENSE (so we can convert it back
to html for about:credits).

The Strongtalk one is more interesting. I must have patched this locally in
a client and not checked it in. There's a LICENSE.strongtalk in src/v8, so
we need a SPECIAL_CASES rule something like

os.path.join('v8'): {
  "Name": "Strongtalk",
  "URL": "http://www.strongtalk.org",
  "License File": "LICENSE.strongtalk",
},


Can you add evanm@ as a reviewer? I think he'll be more helpful and
responsive than I can be.

Thanks,
Mark


>
>
http://codereview.chromium.**org/9288079/<http://codereview.chromium.org/9288...
>

[Evan Martin, 2012-01-30 21:37:17]

https://chromiumcodereview.appspot.com/9288079/diff/4001/tools/licenses.py
File tools/licenses.py (right):

https://chromiumcodereview.appspot.com/9288079/diff/4001/tools/licenses.py#ne...
tools/licenses.py:146: }
trailing comma here, I think

https://chromiumcodereview.appspot.com/9288079/diff/4001/tools/licenses.py#ne...
tools/licenses.py:193: filename = filename.replace("\\","/")
Why do this?

[jbauman, 2012-01-30 23:09:59]

On 2012/01/30 21:37:17, Evan Martin wrote:
> https://chromiumcodereview.appspot.com/9288079/diff/4001/tools/licenses.py
> File tools/licenses.py (right):
> 
>
https://chromiumcodereview.appspot.com/9288079/diff/4001/tools/licenses.py#ne...
> tools/licenses.py:146: }
> trailing comma here, I think

Fixed.
> 
>
https://chromiumcodereview.appspot.com/9288079/diff/4001/tools/licenses.py#ne...
> tools/licenses.py:193: filename = filename.replace("\\","/")
> Why do this?

Ok, got rid of the need to do this.

[Evan Martin, 2012-01-30 23:12:14]

LGTM

[jbauman, 2012-01-30 23:23:14]

To arv from chrome/browser/resources OWNERS review.

[Mark Larson, 2012-01-31 03:14:19]

+estade, jhawkins (other OWNERS)... not sure whether arv is around right
now.

On Mon, Jan 30, 2012 at 15:23, <jbauman@chromium.org> wrote:

> To arv from chrome/browser/resources OWNERS review.
>
>
https://chromiumcodereview.**appspot.com/9288079/<https://chromiumcodereview....
>

[Evan Stade, 2012-01-31 03:47:52]

this is generated right? rubber stamp lgtm

[commit-bot: I haz the power, 2012-01-31 18:35:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/9288079/9001

[commit-bot: I haz the power, 2012-01-31 18:35:24]

Can't apply patch for file chrome/browser/resources/about_credits.html.
While running patch -p1 --forward --force;
patching file chrome/browser/resources/about_credits.html
Hunk #12 FAILED at 790.
Hunk #16 FAILED at 2164.
Hunk #62 FAILED at 7369.
3 out of 67 hunks FAILED -- saving rejects to file
chrome/browser/resources/about_credits.html.rej