Adding fullscreen mode access to chrome.fileBrowserPrivate API.

Adding fullscreen mode access to chrome.fileBrowserPrivate API.


BUG=chromium-os:23978
TEST=

[Vladislav Kaznacheev, 2012-01-26 16:18:18]

Hi,

Please review this small patch.

Thanks,

  Vlad

[Mihai Parparita -not on Chrome, 2012-01-26 16:39:43]

+Jeremy, who knows full screen

Does this need to be a private API just for the file browser? WebKit has a
webkitRequestFullScreen method on DOM nodes now, can that be used instead?

[jeremya, 2012-01-26 21:31:45]

On 2012/01/26 16:39:43, Mihai Parparita wrote:
> +Jeremy, who knows full screen
> 
> Does this need to be a private API just for the file browser? WebKit has a
> webkitRequestFullScreen method on DOM nodes now, can that be used instead?

The webkitRequestFullScreen mode and the 'browser full-screen' mode (toggled by
the fullscreen button or menu item) are a little different -- the former may be
suitable for your purposes, though :)

[dgozman, 2012-01-27 07:13:13]

LGTM

[Vladislav Kaznacheev, 2012-01-27 13:24:02]

Thanks a lot for the pointer! It worked for me (I am copying you on the new
patch: http://codereview.chromium.org/9298009/). 

While working on it I found that if I remove an iframe which is currently
fullscreen it will crush the tab reliably.

  Vlad



On 2012/01/26 21:31:45, jeremya wrote:
> On 2012/01/26 16:39:43, Mihai Parparita wrote:
> > +Jeremy, who knows full screen
> > 
> > Does this need to be a private API just for the file browser? WebKit has a
> > webkitRequestFullScreen method on DOM nodes now, can that be used instead?
> 
> The webkitRequestFullScreen mode and the 'browser full-screen' mode (toggled
by
> the fullscreen button or menu item) are a little different -- the former may
be
> suitable for your purposes, though :)