Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6311)

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 9288045: PRESUBMIT check for JavaScript style errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: exclude options_bundle.js Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/web_dev_style/js_checker.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/PRESUBMIT.py
diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py
index 2fc84fe3e6800ba2c951638bef6cfa886b5d8f41..dc2932f3a402498b47ce945bf1126210c5c53b1c 100644
--- a/chrome/browser/resources/PRESUBMIT.py
+++ b/chrome/browser/resources/PRESUBMIT.py
@@ -36,7 +36,7 @@ def _CommonChecks(input_api, output_api):
try:
sys.path.insert(0, resources)
- from web_dev_style import css_checker
+ from web_dev_style import css_checker, js_checker
# TODO(dbeam): Remove this filter eventually when ready.
def file_filter(affected_file):
@@ -46,6 +46,8 @@ def _CommonChecks(input_api, output_api):
results.extend(css_checker.CSSChecker(input_api, output_api,
file_filter=file_filter).RunChecks())
+ results.extend(js_checker.JSChecker(input_api, output_api,
+ file_filter=file_filter).RunChecks())
finally:
sys.path = old_path
« no previous file with comments | « no previous file | chrome/browser/resources/web_dev_style/js_checker.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698